Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTemporary ResourceTask in parse_inline_css triggers channel send failure #2121
Labels
Comments
bors-servo
pushed a commit
that referenced
this issue
Apr 18, 2014
…lure, r=jdm Fixes #2121 I thought this would be better than passing an `Option<ResourceTask>` to `parse_css` because it avoids having to handle the potential failure at runtime when unwrapping. No test included, but the error was reproducible by running content/test_getBoundingClientRect.html, and this fixes it. Glad to find a way to add an explicit test if need be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Run about-mozilla.html and see the ResourceTask failure message. We just need to either pass in a ResourceTask to parse_inline_css or change the code that requires one to take an Option instead.