Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upScriptTask channel send failure when closing a page containing an iframe #2122
Labels
Comments
Member
jdm
commented
Apr 15, 2014
|
We're trying to send the node to the layout task, but it apparently doesn't exist. That's a problem. |
|
This occurs in |
bors-servo
pushed a commit
that referenced
this issue
Nov 14, 2014
…ntDocument, r=jdm Because of #2122 I cannot write test for this right now because it will be failing randomly due to that iframe issue. However, if it doesn't fail due to that issue a test like this: ```html <html> <head> <meta charset="utf8" /> <script src="harness.js"></script> <title>Iframe contentDocument test.</title> </head> <body> <iframe src="test_iframe_contentDocument_inner.html" id="iframe"></iframe> <script> waitForExplicitFinish(); var timeout = 100; var iframe = document.getElementById('iframe'); function test_contentWindow() { if (!iframe.contentWindow) { // Iframe not loaded yet, try again. // No load event for iframe, insert bug number here. setTimeout(test_contentWindow, timeout); return; } is(iframe.contentDocument.getElementById('test').textContent, 'value'); finish(); } test_contentWindow(); </script> </body> </html> ``` where inner is simply: ```html <html><body><div id="test">value</div></body></html> ``` passes. I have added `SameOrigin` method to the `UrlHelper`. I wanted to reuse it in [`constellation.rs` same_script check](https://github.com/servo/servo/blob/f0184a2d011e12845258a242d2d2f6b8b504a28d/components/compositing/constellation.rs#L625) but I it didn't want to compile saying ``` error: unresolved import `dom::urlhelper::UrlHelper`. Maybe a missing `extern crate dom`? ``` So I didn't include it in this PR for now. There is more discussion about the cross origin iframes in [another issue](#3939). In this PR I just added same origin check.
bors-servo
pushed a commit
that referenced
this issue
Nov 14, 2014
…ntDocument, r=jdm Because of #2122 I cannot write test for this right now because it will be failing randomly due to that iframe issue. However, if it doesn't fail due to that issue a test like this: ```html <html> <head> <meta charset="utf8" /> <script src="harness.js"></script> <title>Iframe contentDocument test.</title> </head> <body> <iframe src="test_iframe_contentDocument_inner.html" id="iframe"></iframe> <script> waitForExplicitFinish(); var timeout = 100; var iframe = document.getElementById('iframe'); function test_contentWindow() { if (!iframe.contentWindow) { // Iframe not loaded yet, try again. // No load event for iframe, insert bug number here. setTimeout(test_contentWindow, timeout); return; } is(iframe.contentDocument.getElementById('test').textContent, 'value'); finish(); } test_contentWindow(); </script> </body> </html> ``` where inner is simply: ```html <html><body><div id="test">value</div></body></html> ``` passes. I have added `SameOrigin` method to the `UrlHelper`. I wanted to reuse it in [`constellation.rs` same_script check](https://github.com/servo/servo/blob/f0184a2d011e12845258a242d2d2f6b8b504a28d/components/compositing/constellation.rs#L625) but I it didn't want to compile saying ``` error: unresolved import `dom::urlhelper::UrlHelper`. Maybe a missing `extern crate dom`? ``` So I didn't include it in this PR for now. There is more discussion about the cross origin iframes in [another issue](#3939). In this PR I just added same origin check.
|
Doesn't seem true anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
