Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDriver "Navigate to URL" returns success on network errors #21248

Open
SimonSapin opened this issue Jul 25, 2018 · 0 comments
Open

WebDriver "Navigate to URL" returns success on network errors #21248

SimonSapin opened this issue Jul 25, 2018 · 0 comments
Labels

Comments

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Jul 25, 2018

Steps to reproduce:

  • Run ./mach run servo --webdriver 4444
  • In another terminal, run PYTHONPATH=tests/wpt/web-platform-tests/tools/webdriver python -c 'import webdriver; webdriver.Session("localhost", 4444).url = "http://this-domain-name-does-not-exist"'

Observed result in 65df9cb: the Servo window shows "Error loading the page", but the Python command runs successfully.

Expected result: as part of executing the command, the WebDriver server inside Servo should run the post-navigation checks, see that the navigation response is a network error, and propagate that error in the WebDriver response. The WebDriver client would then raise a Python exception to indicate this error.

(This came up in #21242, where wptrunner is the WebDriver client.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.