Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWebDriver "Navigate to URL" returns success on network errors #21248
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
./mach run servo --webdriver 4444PYTHONPATH=tests/wpt/web-platform-tests/tools/webdriver python -c 'import webdriver; webdriver.Session("localhost", 4444).url = "http://this-domain-name-does-not-exist"'Observed result in 65df9cb: the Servo window shows "Error loading the page", but the Python command runs successfully.
Expected result: as part of executing the command, the WebDriver server inside Servo should run the post-navigation checks, see that the navigation response is a network error, and propagate that error in the WebDriver response. The WebDriver client would then raise a Python exception to indicate this error.
(This came up in #21242, where
wptrunneris the WebDriver client.)