Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderbufferStorage with RGB565 format causes panic in GL thread #21252

Closed
jdm opened this issue Jul 26, 2018 · 2 comments
Closed

renderbufferStorage with RGB565 format causes panic in GL thread #21252

jdm opened this issue Jul 26, 2018 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 26, 2018

<canvas id="canvas"></canvas>
<script>
  var gl = document.getElementById('canvas').getContext('webgl');
  var buffer = gl.createRenderbuffer();
  gl.bindRenderbuffer(gl.RENDERBUFFER, buffer);
  gl.renderbufferStorage(gl.RENDERBUFFER, gl.RGB565, 1, 1);
  console.log(gl.getError());
</script>

This yields:

ERROR 2018-07-26T16:43:52Z: canvas::webgl_thread: Last GL operation failed: RenderbufferStorage(36161, 36194, 1, 1)
assertion failed: `(left == right)`
  left: `1280`,
 right: `0`: Unexpected WebGL error: 0x500 (1280) (thread WebGLThread, at components/canvas/webgl_thread.rs:1131)

The RGB565 format is allowed by the spec and checked in the conformance tests. This does not affect headless builds using OSMesa, so I'm going to see if Firefox's implementation does anything special here.

@jdm jdm self-assigned this Jul 26, 2018
@jdm
Copy link
Member Author

@jdm jdm commented Jul 27, 2018

I have a local branch that addresses this.

@jdm jdm mentioned this issue Aug 1, 2018
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Aug 2, 2018
Framebuffer and renderbuffer fixes

This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21252
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21313)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Aug 2, 2018
Framebuffer and renderbuffer fixes

This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21252
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21313)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Aug 2, 2018
Framebuffer and renderbuffer fixes

This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21252
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21313)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Aug 2, 2018
Framebuffer and renderbuffer fixes

This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21252
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21313)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Aug 2, 2018
Framebuffer and renderbuffer fixes

This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21252
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21313)
<!-- Reviewable:end -->
@atouchet atouchet added this to Done in WebGL content Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
WebGL content
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.