PerformanceResourceTiming: duration

[avadacatavra]

In components/net/http_loader.rs::http_fetch we need to set duration for the PerformanceEntry member of PerformanceResourceTiming. This will be the difference between response_end and start_time

Spec: https://w3c.github.io/resource-timing/#dfn-duration

[highfive]

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

[haedaal]

@highfive assign me :)

[highfive]

Hey @haedaal! Thanks for your interest in working on this issue. It's now assigned to you!

[jdm]

@haedaal Are you still working on this? Do you have any questions?

[vn-ki]

@highfive assign me

[highfive]

Hey @vn-ki! Thanks for your interest in working on this issue. It's now assigned to you!

[vn-ki]

@jdm Can you please give some pointers where to start? I looked into components/net/http_loader.rs::http_fetch. I'm not sure what to change.

[jdm]

I believe that this does not require any changes to the code in components/net; it only requires computing the difference between the responseEnd and fetchStart values in components/script/dom/performanceresourcetiming.rs and adding the interface attribute in components/script/dom/webidls/PerformanceResourceTiming.webidl. However, we do not implement responseEnd yet, so you should probably fix #21263 first.

[vn-ki]

components/script/dom/performanceresourcetiming.rs

I can't find a file named that.

[jdm]

https://github.com/servo/servo/blob/master/components/script/dom/performanceresourcetiming.rs

[nagashayan]

@highfive assign me

[highfive]

Hey @nagashayan! Thanks for your interest in working on this issue. It's now assigned to you!

[nagashayan]

I see responseEnd and fetchStart is fixed now. this should be good to go now.

[jdm]

Great!

[nagashayan]

The duration attribute MUST return a DOMHighResTimeStamp equal to the difference between responseEnd and startTime, respectively.

[nagashayan]

startTime issue #21254 should be completed before we can work on duration. I see the PR is here davidweitzenfeld#1 but its for forked branch. @jdm right?

[jdm]

Indeed. If you want to cherry-pick that commit and build on top of it, that would be fine.

[nagashayan]

right! I will do that. thanks.

[nagashayan]

I started by cherry-picking on #21254 PR (in another forked repo), it seems that PR itself is not complete. starttime is not implemented in performanceresourcetiming.rs file.

[jdm]

@nagashayan Are you still working on this?

[nagashayan]

@jdm yes, this weekend I will try to finish.

[nagashayan]

@jdm Just refreshed my memory I am waiting on 21254 issue to be resolved. I need that value to complete this PR. what do you think?

[jdm]

Unassigning due to lack of activity.

[aug2uag]

@jdm i cherry-picked the commits from David as mentioned a couple messages above and everything builds nice

no tests i don't know where to put them besides w3c_navigation_timing.js and there its completely empty at the moment plus the documentation for how to run it seems to be missing?

if PR #24493 looks good to you please assign me, if assigned please advise whether adding a setter function in PerformanceEntry that's called from PerformanceResourceTiming to set duration is the way to go-- also webidls look up-to-date and about the tests