Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPerformanceResourceTiming: RedirectEnd #21257
Comments
|
@highfive: assign me |
|
Hey @verma-varsha! Thanks for your interest in working on this issue. It's now assigned to you! |
|
#22561 was a good start but was incomplete. |
|
Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the If you intend to work on this issue, then add |
|
@highfive: assign me Hi! I'm pretty new to open-source contribution, all things considered, but I look forward to working with everyone! |
|
Hey @stmobo! Thanks for your interest in working on this issue. It's now assigned to you! |
|
Unassigning due to lack of activity. |
|
@highfive assign me |
|
Hey @tdelacour! Thanks for your interest in working on this issue. It's now assigned to you! |
ISSUE-21257: set redirectEnd on PerformanceResourceTiming <!-- Please describe your changes on the following line: --> Added the appropriate attribute and setters. Included a Timer struct with a `Drop` function to set this value to zero in error cases. Set the value to `responseEnd` on success. Eliminated tests that now pass. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21257 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23812) <!-- Reviewable:end -->
ISSUE-21257: set redirectEnd on PerformanceResourceTiming <!-- Please describe your changes on the following line: --> Added the appropriate attribute and setters. Included a Timer struct with a `Drop` function to set this value to zero in error cases. Set the value to `responseEnd` on success. Eliminated tests that now pass. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21257 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23812) <!-- Reviewable:end -->
In components/net/http_loader.rs::http_fetch we need to set redirect_end.
On getting, the redirectEnd attribute MUST return as follows:
https://w3c.github.io/resource-timing/#dom-performanceresourcetiming-redirectend