Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerformanceResourceTiming: domainLookupStart #21259

Closed
avadacatavra opened this issue Jul 27, 2018 · 7 comments
Closed

PerformanceResourceTiming: domainLookupStart #21259

avadacatavra opened this issue Jul 27, 2018 · 7 comments
Labels
A-perf-measurement C-assigned E-easy

Comments

@avadacatavra
Copy link
Contributor

@avadacatavra avadacatavra commented Jul 27, 2018 •
edited

In components/net/http_loader.rs::http_fetch we need to set domain_lookup_start (if we're using a persistent connection). Otherwise, domain lookup should be performed by hyper, which is probably out of the scope of this issue.

On getting, the domainLookupStart attribute MUST return as follows:

  1. The same value as fetchStart, if a persistent connection [RFC7230] is used or the resource is retrieved from relevant application caches or local resources.
  2. The time immediately after the user agent before the domain data retrieval from the domain information cache, if the user agent has the domain information in cache.
  3. The time immediately before the user agent starts the domain name lookup for the resource, if the last non-redirected fetch of the resource passes the timing allow check algorithm.
  4. zero, otherwise.

Spec: https://w3c.github.io/resource-timing/#dom-performanceresourcetiming-domainlookupstart
@avadacatavra avadacatavra mentioned this issue Jul 27, 2018
Open
12 of 19 tasks complete
@highfive
Copy link

@highfive highfive commented Nov 29, 2018

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄
@vuamitom
Copy link

@vuamitom vuamitom commented Dec 13, 2018

Hi @avadacatavra ,

I've started on the code and trying to picture rough steps to complete this task, which would be like:

  1. In components/net_traits/lib.rs modify ResourceFetchTiming and ResourceAttribute to add domain_lookup_start
  2. In components/net/http_loader.rs::http_fetch , set domain_lookup_start according to the logic cited above. domain_lookup_start can be set with smth like context.timing.lock().unwrap().setAttribute(....)

Anything incorrect about this? Thanks.
@KiChjang KiChjang added the C-assigned label Dec 13, 2018
@jdm
Copy link
Member

@jdm jdm commented Jan 14, 2019

@vuamitom Sorry for overlooking your questions! That looks like you have the right idea!
@jdm
Copy link
Member

@jdm jdm commented Feb 11, 2019

@vuamitom Are you still working on this?
@vuamitom
Copy link

@vuamitom vuamitom commented Feb 13, 2019

Hi @jdm I have not made any progress since my last question posted. Please feel free to re-assign if you need the issue resolved quicker.
@jdm jdm removed the C-assigned label Feb 27, 2019
@KaczuH
Copy link

@KaczuH KaczuH commented May 2, 2019

@highfive: assign me
@highfive
Copy link

@highfive highfive commented May 2, 2019

Hey @KaczuH! Thanks for your interest in working on this issue. It's now assigned to you!
@highfive highfive added the C-assigned label May 2, 2019
@KaczuH KaczuH mentioned this issue May 2, 2019
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this issue May 8, 2019
@bors-servo
Auto merge of #23310 - KaczuH:add-domain-lookup-start, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
27f726c 
Add domain_lookup_start functionality

<!-- Please describe your changes on the following line: -->
Added the domain_lookup_start functionality in http_loader.rs (http_redirect_fetch function)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21259 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23310)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 19, 2019
@bors-servo
Auto merge of #23310 - KaczuH:add-domain-lookup-start, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b315bc9 
Add domain_lookup_start functionality

<!-- Please describe your changes on the following line: -->
Added the domain_lookup_start functionality in http_loader.rs (http_redirect_fetch function)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21259 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23310)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 20, 2019
@bors-servo
Auto merge of #23310 - KaczuH:add-domain-lookup-start, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
42bc927 
Add domain_lookup_start functionality

<!-- Please describe your changes on the following line: -->
Added the domain_lookup_start functionality in http_loader.rs (http_redirect_fetch function)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21259 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23310)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 29, 2019
@bors-servo
Auto merge of #23310 - KaczuH:add-domain-lookup-start, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fd7bc18 
Add domain_lookup_start functionality

<!-- Please describe your changes on the following line: -->
Added the domain_lookup_start functionality in http_loader.rs (http_redirect_fetch function)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21259 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23310)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 30, 2019
@bors-servo
Auto merge of #23310 - KaczuH:add-domain-lookup-start, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
489ff5e 
Add domain_lookup_start functionality

<!-- Please describe your changes on the following line: -->
Added the domain_lookup_start functionality in http_loader.rs (http_redirect_fetch function)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21259 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23310)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-perf-measurement C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add domain_lookup_start functionality
6 participants
@jdm @vuamitom @KiChjang @highfive @KaczuH @avadacatavra
You can’t perform that action at this time.