Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up--device-pixel-ratio regression #21277
Closed
Comments
bors-servo
added a commit
that referenced
this issue
Aug 6, 2018
Fix page size when device-pixel-ratio is set manually Fix #21277 We were using the user-define pixel ratio to get the device values of the winit coordinates. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21302) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Aug 7, 2018
Fix page size when device-pixel-ratio is set manually Fix #21277 We were using the user-define pixel ratio to get the device values of the winit coordinates. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21302) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using the
--device-pixel-ratiooption, the rendered area doesn't fill the window anymore. Tested on a xps 13 running Ubuntu 18.04.Here on the left no ratio was specified, and on the right a ratio of 2 (which is right on my hidpi screen) is used.
#14431 seems related, but here I'm not even setting the resolution.