Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent pass in /html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window.html #21279

Closed
jdm opened this issue Jul 29, 2018 · 0 comments
Closed

Intermittent pass in /html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window.html #21279

jdm opened this issue Jul 29, 2018 · 0 comments
Labels
I-intermittent

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 29, 2018 

  ▶ Unexpected subtest result in /html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window.html:
  └ PASS [expected FAIL] document.open() after parser is aborted
@jdm jdm added the I-intermittent label Jul 29, 2018
@jdm jdm mentioned this issue Jul 29, 2018
Merged
@pshaughn pshaughn mentioned this issue Jan 2, 2020
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jan 2, 2020
@bors-servo
Auto merge of #25414 - pshaughn:activeparserabort, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
19c5ee5 
Add "active parser was aborted boolean" to Document

Aborting the document now definitely prevents a subsequent document.open from working, per spec as seen in #24458.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #24458 and fix #21279

<!-- Either: -->
- [X] There are tests for these changes (currently intermittent in #21279, this will make them deterministically pass)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Jan 3, 2020
@bors-servo
Auto merge of #25414 - pshaughn:activeparserabort, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3824ce8 
Add "active parser was aborted boolean" to Document

Aborting the document now definitely prevents a subsequent document.open from working, per spec as seen in #24458.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #24458 and fix #21279

<!-- Either: -->
- [X] There are tests for these changes (currently intermittent in #21279, this will make them deterministically pass)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo bors-servo closed this in 2488213 Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-intermittent
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add "active parser was aborted boolean" to Document
1 participant
@jdm
You can’t perform that action at this time.