Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Box::border_box a size, not a rect #2142

Open
pcwalton opened this issue Apr 17, 2014 · 2 comments
Open

Make Box::border_box a size, not a rect #2142

pcwalton opened this issue Apr 17, 2014 · 2 comments

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Apr 17, 2014

It overlaps in confusing ways with Box::border_box. Box::border_box is the canonical source of this information. Right now, BaseFlow::position is mostly just used to store height and offset information that block flows need to perform block layout, but this can be moved into BlockFlow and/or split out from position as appropriate.

I think that height is the only thing that is really needed as part of BaseFlow, so that block flows know how tall their kids are without having to ask them to go to their box list. Maybe width too, for floats.

@SimonSapin You're probably interested in this, as you alluded to this as a source of confusion.

@pcwalton pcwalton changed the title Remove BaseFlow::position Make Box::border_box a size, not a rect Apr 17, 2014
@pcwalton
Copy link
Contributor Author

@pcwalton pcwalton commented Apr 17, 2014

The title reflects what I think should be done now. Obviously I wasn't thinking straight when I wrote the above: the flows need to have position information so that parents can lay out their kids.

@dralley
Copy link
Contributor

@dralley dralley commented Apr 10, 2020

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.