Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake Box::border_box a size, not a rect #2142
Open
Labels
Comments
|
The title reflects what I think should be done now. Obviously I wasn't thinking straight when I wrote the above: the flows need to have position information so that parents can lay out their kids. |
|
Is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It overlaps in confusing ways with
Box::border_box.Box::border_boxis the canonical source of this information. Right now,BaseFlow::positionis mostly just used to store height and offset information that block flows need to perform block layout, but this can be moved intoBlockFlowand/or split out frompositionas appropriate.I think that height is the only thing that is really needed as part of
BaseFlow, so that block flows know how tall their kids are without having to ask them to go to their box list. Maybe width too, for floats.@SimonSapin You're probably interested in this, as you alluded to this as a source of confusion.