Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on macOS since gstreamer addition #21423

Closed
cadeyrn opened this issue Aug 15, 2018 · 5 comments
Closed

Build fails on macOS since gstreamer addition #21423

cadeyrn opened this issue Aug 15, 2018 · 5 comments
Labels

Comments

@cadeyrn
Copy link

@cadeyrn cadeyrn commented Aug 15, 2018

Similar to #21418, but for macOS since the other issue is already closed.

error: failed to run custom build command for gstreamer-sys v0.5.0
process didn't exit successfully: /Users/cadeyrn/localhost/servo/target/release/build/gstreamer-sys-d446d77d0aaad3cc/build-script-build (exit code: 1)
--- stderr
"pkg-config" "--libs" "--cflags" "gstreamer-1.0 >= 1.12" did not exit successfully: exit code: 1
--- stderr
Package gstreamer-1.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gstreamer-1.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gstreamer-1.0' found

@jdm
Copy link
Member

@jdm jdm commented Aug 15, 2018

#21422 updates the readme to include homebrew instructions.

@kingdido999
Copy link
Contributor

@kingdido999 kingdido999 commented Aug 16, 2018

After brew install the updated dependencies, I see this error when I try to build using ./mach build -d on OSX:

   Compiling gstreamer-video-sys v0.5.0
error: failed to run custom build command for `gstreamer-video-sys v0.5.0`
process didn't exit successfully: `/Users/Desmond/repo/servo/target/debug/build/gstreamer-video-sys-336c5a164501da55/build-script-build` (exit code: 1)
--- stderr
`"pkg-config" "--libs" "--cflags" "gstreamer-video-1.0 >= 1.12"` did not exit successfully: exit code: 1
--- stderr
Package gstreamer-video-1.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gstreamer-video-1.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gstreamer-video-1.0' found
@kingdido999 kingdido999 mentioned this issue Aug 16, 2018
2 of 4 tasks complete
@jdm
Copy link
Member

@jdm jdm commented Aug 16, 2018

@kingdido999 That's strange, since gstreamer-video should be part of the dependencies installed by the full command in #21422 per Homebrew/homebrew-core#20014 :/

@cadeyrn
Copy link
Author

@cadeyrn cadeyrn commented Aug 16, 2018

For me it worked with the instructions in #21422 (macOS Mojave Public Beta).

bors-servo added a commit that referenced this issue Aug 16, 2018
Format component allocator

<!-- Please describe your changes on the following line: -->
Format `components/allocator` with:

```bash
rustfmt components/allocator/*.rs
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors. Waiting for #21423 to be resolved.
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix a part of #21373.
- [x] These changes do not require tests because they format the code only.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21428)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Aug 16, 2018
Format component allocator

<!-- Please describe your changes on the following line: -->
Format `components/allocator` with:

```bash
rustfmt components/allocator/*.rs
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors. Waiting for #21423 to be resolved.
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix a part of #21373.
- [x] These changes do not require tests because they format the code only.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21428)
<!-- Reviewable:end -->
@kingdido999
Copy link
Contributor

@kingdido999 kingdido999 commented Aug 17, 2018

It works now after I redo the brew install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.