Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis-CI config for GStreamer dependency #21443

Closed
SimonSapin opened this issue Aug 17, 2018 · 5 comments
Closed

Travis-CI config for GStreamer dependency #21443

SimonSapin opened this issue Aug 17, 2018 · 5 comments

Comments

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Aug 17, 2018

@ferjm Is it really necessary to build gstreamer from source like you do in #21158 in order to be able to build Servo on Travis-CI? Adding dependencies per README in servo/servo-with-rust-nightly@91c90e4 didn’t work: https://travis-ci.org/servo/servo-with-rust-nightly/jobs/416837548

@SimonSapin
Copy link
Member Author

@SimonSapin SimonSapin commented Aug 17, 2018

Ah sorry, I didn’t pay enough attention to the error message beyond "it’s pkg-config"

Requested 'gstreamer-1.0 >= 1.12' but version of GStreamer is 1.2.4

So GStreamer is found, but not a recent enough version. What would it take to support older versions?

@jdm
Copy link
Member

@jdm jdm commented Aug 17, 2018

The restriction about versions comes from https://github.com/sdroege/gstreamer-rs/#linuxbsds.

@ferjm
Copy link
Member

@ferjm ferjm commented Aug 23, 2018

IIUC we are not building GStreamer from source. We fetch a tarball with 1.14.1 binaries already built for
trusty
. Check #21158 (comment)

@ferjm
Copy link
Member

@ferjm ferjm commented Aug 28, 2018

It seems that this was already fixed in servo/servo-with-rust-nightly@1ada617 , so I am closing this issue. Please, reopen if you still think it's valid.

@ferjm ferjm closed this Aug 28, 2018
@SimonSapin
Copy link
Member Author

@SimonSapin SimonSapin commented Aug 29, 2018

I fixed the immediate build failures by copying the config in this repo, but downloading a random tarball still doesn’t feel like a satisfying solution. Hopefully we’ll figure out something better at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.