Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSM60 regression: can't build for Android on Mac #21469
Closed
Comments
Contributor
paulrouget
commented
Aug 21, 2018
|
It looks like sysroot and/or isystem are not used. |
bors-servo
added a commit
that referenced
this issue
Aug 21, 2018
Fix build errors when cross-compiling to android on mac. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21469 - [x] These changes do not require tests because how ridiculous would it be to have CI for a tier 1 platform?
bors-servo
added a commit
that referenced
this issue
Aug 21, 2018
Fix build errors when cross-compiling to android on mac. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21469 - [x] These changes do not require tests because how ridiculous would it be to have CI for a tier 1 platform? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21474) <!-- Reviewable:end -->
|
|
|
What is the Linux failure? |
My bad. I was thinking of that error: servo/mozjs#148 (comment) |
|
Updating the Cargo.toml override:
|
Merged
bors-servo
added a commit
that referenced
this issue
Sep 25, 2018
Upgrade mozjs. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21469 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21805) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 25, 2018
Upgrade mozjs. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21469 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21805) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 25, 2018
Upgrade mozjs. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21469 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21805) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 25, 2018
Upgrade mozjs. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21469 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21805) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 25, 2018
Upgrade mozjs. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21469 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21805) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 25, 2018
Upgrade mozjs. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21469 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21805) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment