Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a checklist for adding new native build dependencies #21511

Open
jdm opened this issue Aug 24, 2018 · 1 comment
Open

Create a checklist for adding new native build dependencies #21511

jdm opened this issue Aug 24, 2018 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Aug 24, 2018

I would like to see a wiki page that contains a checklist that needs to be addressed each time a pull request adds a build dependency that requires changes to the native build environment (most recently #21158 and #21029). Items on this checklist should include:

  • updating the build setup instructions in README.md for all tier 1 platforms (windows, debian-based linuxes, mac)
  • updating TravisCI and Appveyor configurations
  • updating saltfs configuration
  • updating configuration of nightly TravisCI servo build using rust nightly
  • considering behaviour of build artifacts available on download.servo.org (c.f. #21414)
@jdm jdm added the A-documentation label Aug 24, 2018
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Aug 24, 2018

In general can we move from wiki pages to in-tree docs? They feel a bit more permanent.

Salt does this already (somewhat) and it's pretty nice.

I can write this when I get time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.