Refactor `CommonScriptMsg::Task` to include the name of the task-source

[gterzian]

Message enum is at:

servo/components/script/script_runtime.rs

Line 54 in da36740

Task(ScriptThreadEventCategory, Box<TaskBox>, Option<PipelineId>),

Name of task sources is found at:

servo/components/script/task_source/mod.rs

Line 24 in da36740

pub enum TaskSourceName {

The CommonScriptMsg::Task should include the task-source name.

Follow up on #21388

See 263ad79#r212802334

[AgustinCB]

I'd like to give this a shot.

[gterzian]

You're welcome to do so. Depending on when #21388 merges, I will either have to rebase off of your work, or you could integrate yours into the TaskQueue...

The later would require changing fn task_category(&self) -> Option<&ScriptThreadEventCategory> into something like fn task_source_name(&self) -> Option<&TaskSourceName> and updating it's use accordingly...
see https://github.com/servo/servo/pull/21388/files#diff-eac74606d6d2a29782f87f355cd3e0bbR23

Some other methods of QueuedTaskConversion, and their use, would require slight adaptations to use the TaskSourceName instead of the ScriptThreadEventCategory...

For example here, obviously the task-source name could be used directly, instead of doing it via the category: https://github.com/servo/servo/pull/21388/files#diff-eac74606d6d2a29782f87f355cd3e0bbR63

and here too: https://github.com/servo/servo/pull/21388/files#diff-eac74606d6d2a29782f87f355cd3e0bbR89

[AgustinCB]

Awesome! I'll start working on this in the afternoon. Thanks.

[AgustinCB]

I just finished the integration previous to your commit. I just rebased and started the other instructions. Hopefully will have a pr in the weekend :)

[gterzian]

Great, looking forward to it.

One thing I didn't mention previously, is that the TaskSourceName also should be added to the QueuedTask

Also, we still want to keep ScriptThreadEventCategory where it is, we just want to use the TaskSourceName instead of it where appropriate(like I mentioned previously)

If anything is unclear, don't hesitate to open a PR with what you have so we can discuss it concretely...

[AgustinCB]

There are some tests failing with this change that I wasn't expecting. I'm digging into them to understand why.

[AgustinCB]

Sorry for commenting in a closed issue, but I didn't know where else I could ask this:

I'd like to keep contributing to the project. I was thinking in addressing #21589 and #21590. They seem pretty straight forward, so I don't expect to be blocked there for long. What other issues could I take? (keeping in mind that I do this after work and I can sadly allocate 5-10 hours/week to the project).

Thanks!

[gterzian]

@AgustinCB thanks for your help.

I think you might also want to take a look at those issues: https://github.com/servo/servo/issues?q=is%3Aopen+is%3Aissue+label%3AE-candidate-for-mentoring

and https://github.com/servo/servo/issues?q=is%3Aopen+is%3Aissue+label%3AB-interesting-project

I personally recommend this one, #17442 it looks like fun and has a mentor available

[ferjm]

@AgustinCB you might be interested in #21481 as well, which is similar to #21590