Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a new `unshipped-port-message-queue` task source on `DedicatedWorkerGlobalScopeMethods::PostMessage` #21589

Open
AgustinCB opened this issue Sep 3, 2018 · 2 comments

Comments

@AgustinCB
Copy link
Contributor

@AgustinCB AgustinCB commented Sep 3, 2018

This call

Should be using a new value in the enum of TaskSourceName referring to unshipped-port-message-queue, as mentioned in https://html.spec.whatwg.org/multipage/#unshipped-port-message-queue

@AgustinCB
Copy link
Contributor Author

@AgustinCB AgustinCB commented Sep 4, 2018

Currently working on this one.

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Sep 12, 2018

I think this issue is unneeded, because it attempts to shoehorn the unshipped port message task source into the existing implementation of DedicatedWorkerGlobalScope::PostMessage, which does not have a concept of a MessagePort yet.

We should instead file a new issue to change all the existing postMessage implementation to use MessagePort underneath once #16622 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.