Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRoot element background should fill entire canvas #218
Comments
|
Turns out that we aren't attaching any boxes to the RootFlow, instead creating a BlockFlow for HTMLHTMLElement. This is no good. |
|
It's the background of the body if this is an HTML document and has a body. Otherwise it's the background of the root element. In either case it's painted over the whole canvas, but the background position and such depends on the box of the root element. Which is important, because the size of the root element's box can easily not match the size of the canvas. |
|
From the spec: "For documents whose root element is an HTML "HTML" element or an XHTML "html" element that has computed values of 'transparent' for 'background-color' and 'none' for 'background-image', user agents must instead use the computed value of the background properties from that element's first HTML "BODY" element or XHTML "body" element child when painting backgrounds for the canvas, and must not paint a background for that child element. Such backgrounds must also be anchored at the same point as they would be if they were painted only for the root element." So, does this mean |
|
The body thing only happens if the HTML background-color is transparent and background-image is "none". I was wrong about that in my comment above. |
|
I believe they are the same. On Dec 11, 2013, at 1:42 AM, Simon Sapin notifications@github.com wrote:
|
|
Thanks @burg for confirming. Closing. |
shadow-dom: Remove shadow-trees/test-003.html in favor of reftests.
Fixes for a couple of panics in WR. - Change resize to not require changing texture ID. - Fix freelist iterator. These changes are slightly less efficient, but fix some panics. We can revisit this code if it shows up in profiles.
We should paint the entire viewport with the background of the root element. The spec seems to imply that this is the background of HTMLBodyElement, but applied to the canvas of HTMLHTMLElement.
Spec: http://www.w3.org/TR/CSS2/colors.html
Talmudic interpretation: https://bugzilla.mozilla.org/show_bug.cgi?id=13473