Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor is broken #21832

Closed
jdm opened this issue Sep 28, 2018 · 1 comment
Closed

Appveyor is broken #21832

jdm opened this issue Sep 28, 2018 · 1 comment
Labels

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 28, 2018

This is a result of #21809 but I don't understand why it's only affecting windows.

rustup -V
rustup 1.12.0 (573895abc 2018-07-07)
mach rustc --version
rustc 1.30.0-nightly (7061b2775 2018-08-28)
mach cargo --version
error: Found argument '--manifest-path' which wasn't expected, or isn't valid in this context
	Did you mean to put '--manifest-path' after the subcommand 'bench'?
USAGE:
    cargo.exe --version
For more information try --help
Command exited with code 1
@jdm jdm added the I-bustage label Sep 28, 2018
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Sep 28, 2018

Maybe we don’t run mach cargo --version on other CI systems? Replacing that with cargo --version (without mach) should be fine now that we use rustup with a rust-toolchain file.

@jdm jdm mentioned this issue Sep 28, 2018
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Oct 1, 2018
Fix appveyor build

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21832
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21833)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.