Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows nightly reports missing gstreamer DLLs #21839

Closed
jdm opened this issue Sep 28, 2018 · 11 comments
Closed

Windows nightly reports missing gstreamer DLLs #21839

jdm opened this issue Sep 28, 2018 · 11 comments
Assignees
Labels

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 28, 2018

16:32 <imago> Hello! I'm trying to install the nightly build of servo on windows 10 64bit to try it out but it basically is lacking gstreamer ("libgstapp-1.0.0.dll was not found"). Any tips? Thanks
16:33 <imago> Or rather, it has 3 or so .dll files missing, all to do with "libg", i assume it gstreamer/gobject related
16:38 <jdm> imago: huh, that problem should have been solved already :<
16:38 <jdm> imago: is this a nightly downloaded today?
16:38 <imago> Yeah, i tried installing it just a few min ago
@jdm jdm added the P-windows label Sep 28, 2018
@atouchet
Copy link
Contributor

@atouchet atouchet commented Sep 28, 2018

Is this using the installer or the ZIP version? Was the GSteamer issue ever fixed for the ZIP version?

@jdm
Copy link
Member Author

@jdm jdm commented Sep 28, 2018

I don't believe the zip was ever fixed.

@ferjm
Copy link
Member

@ferjm ferjm commented Sep 30, 2018

No, the zip does not contain the required GStreamer dlls. I am not sure if we can add them there directly though. Would it be acceptable to add the GStreamer installer to the zip?

@muliar
Copy link

@muliar muliar commented Oct 3, 2018

Latest installer: servo-latest.exe
Launching Servo Tech Demo, Errors:

The code execution cannot proceed because libgstapp-1.0-0.dll was not found. 
The code execution cannot proceed because libgstaudio-1.0-0.dll was not found. 
The code execution cannot proceed because libgstreamer-1.0-0.dll was not found. 
The code execution cannot proceed because libgobject-2.0-0.dll was not found. 
@atouchet
Copy link
Contributor

@atouchet atouchet commented Oct 4, 2018

@muliar do you have GStreamer installed on your C: drive?

@jdm
Copy link
Member Author

@jdm jdm commented Oct 4, 2018

They should not have to have GStreamer installed; the installer should put the files in the right place.

@atouchet
Copy link
Contributor

@atouchet atouchet commented Oct 4, 2018

@jdm last time I ran the installer it put the GStreamer files on the wrong drive and I had to install them manually to get it working.

@muliar
Copy link

@muliar muliar commented Oct 4, 2018

@muliar do you have GStreamer installed on your C: drive?

Good point!
Servo Installer has installed gstreamer onto D:\ somehow yesterday: time modified is an evidence.
That's I do not understand: Windows Installer should install everything to standard %ProgramFiles% directory.

@ferjm
Copy link
Member

@ferjm ferjm commented Oct 4, 2018

Ugh, I have no idea how to do it, but I guess we'd need to inspect the registry to figure out where GStreamer was installed (and hope that GStreamer writes something there) before setting the PATH here.

/me reinstalls a Windows VM :(

@ferjm ferjm self-assigned this Oct 4, 2018
@atouchet
Copy link
Contributor

@atouchet atouchet commented Oct 6, 2018

@ferjm would it be possible to dictate which drive GStreamer is installed to? I feel like the main issue here is that GStreamer sometimes installs to unexpected locations by default instead of C:. The installer from the GStreamer website does the same thing but at least with that one the directory can be changed.

@ferjm
Copy link
Member

@ferjm ferjm commented Oct 9, 2018

I don't know, I guess that's possible. The current installer already allows to manually change the installation path (through the Options menu).

I think it would be safer to get the installation path from the registry. I found that GStreamer writes the HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\GStreamer1.0\x86\InstallDir key in the registry. So we can use that value. I just need to figure out how to do it with WiX (and wait for the long VM builds).

bors-servo added a commit that referenced this issue Oct 10, 2018
Windows installer: set GStreamer installation path based on registry …

…search

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21839

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21902)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 10, 2018
Windows installer: set GStreamer installation path based on registry …

…search

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21839

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21902)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 10, 2018
Windows installer: set GStreamer installation path based on registry …

…search

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21839

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21902)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.