Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWindows nightly reports missing gstreamer DLLs #21839
Comments
jdm
commented
Sep 28, 2018
|
Is this using the installer or the ZIP version? Was the GSteamer issue ever fixed for the ZIP version? |
|
I don't believe the zip was ever fixed. |
|
No, the zip does not contain the required GStreamer dlls. I am not sure if we can add them there directly though. Would it be acceptable to add the GStreamer installer to the zip? |
|
Latest installer: servo-latest.exe
|
|
@muliar do you have GStreamer installed on your C: drive? |
|
They should not have to have GStreamer installed; the installer should put the files in the right place. |
|
@jdm last time I ran the installer it put the GStreamer files on the wrong drive and I had to install them manually to get it working. |
Good point! |
|
Ugh, I have no idea how to do it, but I guess we'd need to inspect the registry to figure out where GStreamer was installed (and hope that GStreamer writes something there) before setting the PATH here. /me reinstalls a Windows VM :( |
|
@ferjm would it be possible to dictate which drive GStreamer is installed to? I feel like the main issue here is that GStreamer sometimes installs to unexpected locations by default instead of C:. The installer from the GStreamer website does the same thing but at least with that one the directory can be changed. |
|
I don't know, I guess that's possible. The current installer already allows to manually change the installation path (through the Options menu). I think it would be safer to get the installation path from the registry. I found that GStreamer writes the |
Windows installer: set GStreamer installation path based on registry … …search - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21839 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21902) <!-- Reviewable:end -->
Windows installer: set GStreamer installation path based on registry … …search - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21839 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21902) <!-- Reviewable:end -->
Windows installer: set GStreamer installation path based on registry … …search - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21839 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21902) <!-- Reviewable:end -->