Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unresponsive scrolling #21991

Closed
ferjm opened this issue Oct 21, 2018 · 7 comments
Closed

Unresponsive scrolling #21991

ferjm opened this issue Oct 21, 2018 · 7 comments
Labels
P-android

Comments

@ferjm
Copy link
Member

@ferjm ferjm commented Oct 21, 2018

Navigating to https://google.com and scrolling up and down eventually makes scrolling unresponsive. Clicking on links continue working.
@ferjm ferjm added the P-android label Oct 21, 2018
@ferjm
Copy link
Member Author

@ferjm ferjm commented Oct 21, 2018

Actually, I see this behavior on other sites like https://servo.org or https://mozilla.org.

I see nothing useful on the logcat.
@ferjm ferjm changed the title Unresponsive scrolling on google.com Unresponsive scrolling Oct 21, 2018
@fabricedesre
Copy link
Contributor

@fabricedesre fabricedesre commented Oct 21, 2018

did you try tweaking the user agent?
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Oct 22, 2018

@ferjm what does the top left label says when it's blocked: IDLE or LOOP?
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Oct 22, 2018

Sometimes, after a fling gesture, we can't scroll anymore.
@ferjm
Copy link
Member Author

@ferjm ferjm commented Oct 22, 2018

did you try tweaking the user agent?

No. Which UA should I set?

what does the top left label says when it's blocked: IDLE or LOOP?

IDLE
@fabricedesre
Copy link
Contributor

@fabricedesre fabricedesre commented Oct 22, 2018

I commented on the wrong issue, sorry. Was meant for #21990
@jdm jdm mentioned this issue Nov 1, 2018
Closed
@LifeIsStrange
Copy link

@LifeIsStrange LifeIsStrange commented Nov 11, 2018 •
edited

@paulrouget « Sometimes, after a fling gesture, we can't scroll anymore. » actually servo is unusable on my android tablet since the beginning of the android port because of this and this is my last big remaining issue (as most things display well else).

After a fling gesture most of my attempt to scroll Again will be ignored and idle.
But if I scroll with my finger always on Touch with the screen then scrolling works..
(still true on the latest nightly)
@paulrouget paulrouget mentioned this issue Nov 12, 2018
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this issue Nov 16, 2018
@bors-servo
Auto merge of #22178 - paulrouget:fixScroll, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9d0837f 
Properly cancel looping before triggering another drawing loop

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21991 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22178)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 16, 2018
@bors-servo
Auto merge of #22178 - paulrouget:fixScroll, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6d3e451 
Properly cancel looping before triggering another drawing loop

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21991 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22178)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 16, 2018
@bors-servo
Auto merge of #22178 - paulrouget:fixScroll, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
20f00d7 
Properly cancel looping before triggering another drawing loop

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21991 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22178)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 17, 2018
@bors-servo
Auto merge of #22178 - paulrouget:fixScroll, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
683173c 
Properly cancel looping before triggering another drawing loop

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21991 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22178)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 17, 2018
@bors-servo
Auto merge of #22178 - paulrouget:fixScroll, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ebafca3 
Properly cancel looping before triggering another drawing loop

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21991 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22178)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 17, 2018
@bors-servo
Auto merge of #22178 - paulrouget:fixScroll, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bee8f62 
Properly cancel looping before triggering another drawing loop

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21991 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22178)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 17, 2018
@bors-servo
Auto merge of #22178 - paulrouget:fixScroll, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6da89a6 
Properly cancel looping before triggering another drawing loop

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21991 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22178)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-android
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Properly cancel looping before triggering another drawing loop
4 participants
@paulrouget @ferjm @fabricedesre @LifeIsStrange
You can’t perform that action at this time.