Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix purity/mutability of RenderBox style-related methods #220

Closed
burg opened this issue Nov 19, 2012 · 1 comment
Closed

Fix purity/mutability of RenderBox style-related methods #220

burg opened this issue Nov 19, 2012 · 1 comment

Comments

@burg
Copy link

@burg burg commented Nov 19, 2012

Methods like can_merge_with_box just compare FontStyle, so they should be pure. It seems that this is not the case because (transitively) Node.get_parent is not pure.

@jdm
Copy link
Member

@jdm jdm commented Apr 1, 2014

If we're talking about purity in terms of mutability, I believe things like get_parent are pure now.

@jdm jdm closed this Apr 1, 2014
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
shadow-dom: Refine script tests related to ownerDocument property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.