Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic Leap minimum viable demo #22043

Closed
asajeffrey opened this issue Oct 29, 2018 · 2 comments
Closed

Magic Leap minimum viable demo #22043

asajeffrey opened this issue Oct 29, 2018 · 2 comments
Labels
P-magic leap

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Oct 29, 2018 •
edited

Features that are needed for a demoable Servo on Magic Leap:

  • Render web content (#21985)
  • Respond to touchpad: hover state plus follow hyperlinks (#22045)
  • Respond to navigation fwd/back (#22057)
  • Respond to URL changes (#22066)
  • Scrolling (#22076)
@blairmacintyre
Copy link

@blairmacintyre blairmacintyre commented Oct 31, 2018

Those seem like a good list.

Is it worth looking at the current Firefox Reality on GO, and listing the things it does that we can/can't do.

For example, things we don't need (or can't do) for an MVD are

  • webvr/webxr
  • private browsing
  • full 3D ray from controller (we'd need to shift to immersive mode for this, anyway)

In terms of difficulty, I have no idea where things like "interact with interactive elements like sliders" falls?
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Oct 31, 2018

@blairmacintyre good point re interacting with web input components. At the moment mouse clicks should work, but not mouse up/down or anything using the keyboard.
@asajeffrey asajeffrey mentioned this issue Nov 1, 2018
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Nov 1, 2018
@bors-servo
Auto merge of #22076 - asajeffrey:magicleap-scroll, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ad32d52 
Support scrolling in Magic Leap Servo

<!-- Please describe your changes on the following line: -->

Add support for scrolling in Magic Leap Servo. Also adds support for mouse down and mouse up events.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22043
- [X] These changes do not require tests because we can't test ML

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22076)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-magic leap
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Support scrolling in Magic Leap Servo
2 participants
@asajeffrey @blairmacintyre
You can’t perform that action at this time.