Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable buffering and caching media data in gstreamer #22055

Closed
jdm opened this issue Oct 30, 2018 · 3 comments
Closed

Enable buffering and caching media data in gstreamer #22055

jdm opened this issue Oct 30, 2018 · 3 comments
Assignees
@ferjm
Labels
A-content/media
Projects
Media playback

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 30, 2018 

<jdm> does gsteamer do any caching, or does it throw away the original buffer it receives?
<ferjm> jdm, I believe so, but I think it requires some setup that we are currently not doing. I need to look into the buffering/caching strategy
@jdm jdm added the A-content/media label Oct 30, 2018
@ferjm ferjm self-assigned this Oct 30, 2018
@ceyusa
Copy link
Collaborator

@ceyusa ceyusa commented Oct 30, 2018

What player/playbin can do (and it would need to be configured in servo/media) is buffering. Basically it stores in a queue the specified size/time of the demuxed data.

Also, player/playbin could be configured for downloading, which will add a special queue after source element, which can cache on disk (until certain size) what it is received from the source element.

In my opinion, adding some buffering would make sense for servo, but I'm to sure about downloading, since that caching perhaps would be better handled by the networking subsystem.
@ceyusa
Copy link
Collaborator

@ceyusa ceyusa commented Oct 30, 2018

After reading #22054 perhaps it would make sense add that feature, temporarily, in media/gstreamer
This was referenced Nov 28, 2018
Closed
Closed
Open
@ferjm ferjm changed the title Investigate caching media data in gstreamer Investigate buffering and caching media data in gstreamer Nov 29, 2018
@ferjm ferjm mentioned this issue Nov 29, 2018
Closed
@ferjm ferjm changed the title Investigate buffering and caching media data in gstreamer Enable buffering and caching media data in gstreamer Nov 29, 2018
@ferjm
Copy link
Member

@ferjm ferjm commented Nov 29, 2018 •
edited

This is currently blocked on https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/508
@ferjm ferjm added this to In progress in Media playback Nov 29, 2018
@ferjm ferjm mentioned this issue Jan 15, 2019
Merged
3 of 3 tasks complete
bors-servo added a commit that referenced this issue Jan 15, 2019
@bors-servo
Auto merge of #22692 - ferjm:buffering, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
788349b 
Media cache and buffering support

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22055 and fix #22296

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22692)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 17, 2019
@bors-servo
Auto merge of #22692 - ferjm:buffering, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ab4c0a4 
Media cache and buffering support

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22055 and fix #22296

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22692)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 17, 2019
@bors-servo
Auto merge of #22692 - ferjm:buffering, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
665568c 
Media cache and buffering support

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22055 and fix #22296

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22692)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 17, 2019
@bors-servo
Auto merge of #22692 - ferjm:buffering, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
866fd55 
Media cache and buffering support

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22055 and fix #22296

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22692)
<!-- Reviewable:end -->
Media playback automation moved this from In progress to Done Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferjm ferjm

Labels
A-content/media
Projects
Media playback
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Media cache and buffering support
3 participants
@ceyusa @jdm @ferjm
You can’t perform that action at this time.