Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Leap build in CI #22078

Closed
asajeffrey opened this issue Nov 1, 2018 · 6 comments
Closed

Magic Leap build in CI #22078

asajeffrey opened this issue Nov 1, 2018 · 6 comments

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Nov 1, 2018

We're currently not running any tests for the --magicleap build in CI. Steps to do this:

AFAICT there's not really any way to run a smoke test, since we don't have ML hardware in CI, but at least this would keep the build alive.

@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Nov 1, 2018

Should we also package the ML app and do a nightly release for it? Or hold off on that until we're happier with the UI?

@jdm
Copy link
Member

@jdm jdm commented Nov 1, 2018

I would be happy to start publishing nightly builds with #22076 merged and these checkboxes checked.

@jdm
Copy link
Member

@jdm jdm commented Nov 1, 2018

By which I mean, yes, #22079 would be necessary before we publish nightly builds.

@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Nov 1, 2018

Ok. Sounds like #22076 is the next step.

@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Nov 1, 2018

Argh, I meant #22079.

@asajeffrey asajeffrey mentioned this issue Nov 6, 2018
3 of 3 tasks complete
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Nov 8, 2018

All merged now, though we're not gating on the ML build.

@asajeffrey asajeffrey closed this Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.