Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DuckDuckGo search results in "forbidden" #22090

Closed
atouchet opened this issue Nov 2, 2018 · 6 comments
Closed

DuckDuckGo search results in "forbidden" #22090

atouchet opened this issue Nov 2, 2018 · 6 comments
Assignees
@jdm
Labels
A-network C-reproduced

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented Nov 2, 2018 •
edited

URL: https://duckduckgo.com/html

Steps to reproduce:

  1. Load https://duckduckgo.com/html
  2. Search something.
  3. The search result page does not appear but instead the text "forbidden" is displayed.

This issue first occurred in the 2018-11-02 nightly build. Tested in Windows 10.
@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Nov 2, 2018

This issue also occurs using the https://duckduckgo.com/ version of the site.
@paulrouget paulrouget mentioned this issue Nov 2, 2018
Open
16 of 24 tasks complete
@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Nov 3, 2018

The search page seems to load normally when not navigated to from the DuckDuckGo home page. For example searching something using the Servo URL prompt still works fine.
@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Dec 3, 2018

This is now only happening with the https://duckduckgo.com/html version of the site.
@jdm jdm added the A-network label Dec 3, 2018
@jdm
Copy link
Member

@jdm jdm commented Dec 3, 2018

This is caused by Servo adding a Origin: https://duckduckgo.com:443 header to the request. This isn't present in Firefox, but I'm not sure why yet.
@jdm jdm added the C-reproduced label Dec 3, 2018
@jdm
Copy link
Member

@jdm jdm commented Dec 3, 2018

Ok, it's not the presence of the header itself. It's the presence of the :443 in the header, since when I set network.http.sendOriginHeader to 1 in Firefox the site still loads.
@jdm
Copy link
Member

@jdm jdm commented Dec 3, 2018

As expected, this is a regression from #21644.
This was referenced Dec 3, 2018
Open
Merged
bors-servo added a commit that referenced this issue Dec 3, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ff765f1 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [ ] There are tests for these changes
@jdm jdm self-assigned this Dec 3, 2018
bors-servo added a commit that referenced this issue Dec 14, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d9e2a01 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 14, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b7083a3 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 14, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fb30fd3 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 15, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3c40aca 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 17, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
18fb6aa 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 17, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
faeba8f 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 18, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
80f5de0 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 18, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
25e1731 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 18, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ba29ab9 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 18, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
be8e2e9 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 18, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7d7a73b 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 19, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c1f45cb 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 22, 2018
@bors-servo
Auto merge of #22354 - jdm:ddg, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9caf215 
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdm jdm

Labels
A-network C-reproduced
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix DuckDuckGo HTML search
2 participants
@jdm @atouchet
You can’t perform that action at this time.