Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crossbeam-channel to v0.3 #22108

Closed
stjepang opened this issue Nov 4, 2018 · 2 comments
Closed

Update crossbeam-channel to v0.3 #22108

stjepang opened this issue Nov 4, 2018 · 2 comments
Labels

Comments

@stjepang
Copy link
Contributor

@stjepang stjepang commented Nov 4, 2018

On a popular request, I've changed the behavior of crossbeam-channel in v0.3 so that dropping all receivers disconnects the channel.

This means we don't need the channel library wrapper around crossbeam-channel anymore. Let's delete it.

Also note that now we can replace select! invocations like the following one with r.try_recv():

select! {
    recv(r, msg) => {},
    default => {},
}

We should update crossbeam-channel in ipc-channel, too.

I'd be happy to review PRs that update it to v0.3, just make sure to cc me!

cc @gterzian @SimonSapin @jdm

@jdm jdm added the I-refactor label Nov 4, 2018
@Eijebong
Copy link
Member

@Eijebong Eijebong commented Nov 4, 2018

I might take a look at it next week if I find time. If anyone else want to work on that, feel free to do so though

@stjepang
Copy link
Contributor Author

@stjepang stjepang commented Nov 18, 2018

Implemented in #22142

@stjepang stjepang closed this Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.