Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in dom/nodes/Element-children.html #2212

Closed
jdm opened this issue Apr 23, 2014 · 2 comments
Closed

Crash in dom/nodes/Element-children.html #2212

jdm opened this issue Apr 23, 2014 · 2 comments
Labels
A-content/bindings I-crash

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 23, 2014

Our proxy bindings like HTMLCollection need to implement an enumerate trap, since it's pure-virtual in C++ and we don't provide one right now.
@jdm
Copy link
Member Author

@jdm jdm commented Apr 23, 2014

This will need a combination of BaseDOMProxyHandler::enumerate and CGEnumerateHook.
@jdm jdm added the I-crash label Apr 23, 2014
@jdm jdm mentioned this issue Nov 20, 2014
Closed
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Dec 25, 2014

The crash was fixed in 919f221; I'll leave the remainder for #4043.
@Ms2ger Ms2ger closed this Dec 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings I-crash
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @Ms2ger
You can’t perform that action at this time.