Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delete proxy trap #2213

Closed
jdm opened this issue Apr 23, 2014 · 2 comments
Closed

Implement delete proxy trap #2213

jdm opened this issue Apr 23, 2014 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 23, 2014

It's required, and it doesn't exist. I'm pretty sure this just needs to forward the delete operation to the proxy expando (see DOMProxyHandler::delete_ in gecko). This can just be a simple method in dom/bindings/proxyhandler.rs that's shared by all DOM proxies.

@jdm
Copy link
Member Author

@jdm jdm commented Apr 23, 2014

The relevant place to make use of the new trap is in the delete_ field in the ProxyTrap structure that's generated in CodegenRust.py.

@jdm
Copy link
Member Author

@jdm jdm commented Apr 23, 2014

ngsankha added a commit to ngsankha/servo that referenced this issue May 20, 2014
Ms2ger added a commit to Ms2ger/servo that referenced this issue Jul 29, 2014
@Ms2ger Ms2ger closed this in 6b44f92 Jul 29, 2014
Ms2ger added a commit that referenced this issue Jul 29, 2014
Implement the delete proxy trap (fixes #2213); r=jdm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.