Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable taking stack snapshots of other threads: The Linux/Android edition #22203
Comments
jdm
added
P-linux
P-android
labels
Nov 15, 2018
This comment has been minimized.
This comment has been minimized.
nikhilm
commented
Nov 21, 2018
|
FWIW, I have a work in progress library (i only made it publicly viewable so i could post this, heh! still needs documentation and so on) for a sampling profiler. https://bitbucket.org/nikhilm/vignette. |
This comment has been minimized.
This comment has been minimized.
|
@nikhilm thanks! I'll restructure the Mac-Os one to use a similar I assume your Also, your implementation of For the yet to be implemented resolving of the frames, we can use I'll focus on re-structuring the Mac part, as well as the overall structure, so that it will "fit" better with this, I might try the actual Linux implementation after that, and if anyone else is interested, just let me know... |
gterzian commentedNov 15, 2018
Follow up on #16740
Code in
components/background_hang_monitor/sampler.rs(yet to be merged from #21673)The suspending/resuming of a thread is (perhaps only partly) implemented, and it is mainly accessing the instruction and frame pointers in the registers, as well as perhaps the stack walking, that needs to be (re-)implemented for Linux/Android.
I think target architectures for Linux would be
x86_64, and for Android it would bex86for the emulator, andarmfor the devices.It appears that
libcwould be the appropriate tool in both cases.See also the Gecko implementation at https://dxr.mozilla.org/mozilla-central/rev/b0b856065d5b7ad2996f707e6e797d0d72afd803/tools/profiler/core/platform-linux-android.cpp#85