Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken text on Android #22232

Closed
Darkspirit opened this issue Nov 20, 2018 · 17 comments
Closed

Broken text on Android #22232

Darkspirit opened this issue Nov 20, 2018 · 17 comments

Comments

@Darkspirit
Copy link
Contributor

@Darkspirit Darkspirit commented Nov 20, 2018 •
edited

Many letters disappear when scrolling down.
Device: Motorola Moto G5, Android 8.1.0
Screencast: https://youtu.be/aLHPtEsWBQI

last good:
https://dl.servo.org/nightly/android/2018-11-18T02:08:52Z-servoapp.apk
https://build.servo.org/builders/android-nightly/builds/968

first bad:
https://dl.servo.org/nightly/android/2018-11-19T02:09:21Z-servoapp.apk
https://build.servo.org/builders/android-nightly/builds/969

regression range:
34bf312...eb3af18
@Darkspirit
Copy link
Contributor Author

@Darkspirit Darkspirit commented Nov 20, 2018 •
edited

Could bug 1505508 - Intermittently missing glyphs on Android (GeckoView) be related?

Edit: Probably. CPU-Z says: GPU Renderer: Adreno 505
servo/webrender#3327 might help?
@LifeIsStrange
Copy link

@LifeIsStrange LifeIsStrange commented Nov 20, 2018

I can reproduce on my galaxy tab s2
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 20, 2018

I can verify that the breaking commit is 76195e0
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 20, 2018

I don't think this is a glutin issue, android doesn't use glutin
@jdm
Copy link
Member

@jdm jdm commented Nov 20, 2018

Pretty sure it's the webrender upgrade: 76195e0#diff-d2ede298d9a75c849170d6ef285eda1eR4527
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 20, 2018

Yeah, I'm looking into that now. Definitely looks like a broken atlas
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 20, 2018

That patch doesn't fix it
@Darkspirit
Copy link
Contributor Author

@Darkspirit Darkspirit commented Nov 20, 2018 •
edited

Pretty sure it's the webrender upgrade: 76195e0#diff-d2ede298d9a75c849170d6ef285eda1eR4527

servo/webrender@790b76f...9ec08a4
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 20, 2018

Working on it, I've got a smaller regression range between servo/webrender@46ee0ff...b44b571
@Darkspirit
Copy link
Contributor Author

@Darkspirit Darkspirit commented Nov 20, 2018

servo/webrender#3282 caused bug 1505664.
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 20, 2018

Yeah, my bisection is pointing fingers at servo/webrender@ab887f2 too
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 20, 2018

I guess a WR update will fix everything?
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 21, 2018

Nope. I did the WR update, still broken.
@Manishearth Manishearth mentioned this issue Nov 21, 2018
Merged
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 21, 2018 •
edited

I realized there was a problem with the way I was patching webrender -- so it's possible that servo/webrender#3327 will help after all. Testing this.
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 21, 2018

servo/webrender#3327 does indeed fix this
@Manishearth Manishearth mentioned this issue Nov 21, 2018
Closed
bors-servo added a commit that referenced this issue Nov 27, 2018
@bors-servo
Auto merge of #22237 - Manishearth:wrup, r=pcwalton
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
af570ac 
Update webrender

Fixes #22232 , once servo/webrender#3327 lands and I update this PR to include it

All the integer casts are due to servo/webrender#3291

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22237)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 27, 2018
@bors-servo
Auto merge of #22237 - Manishearth:wrup, r=pcwalton
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8c7af0f 
Update webrender

Fixes #22232 , once servo/webrender#3327 lands and I update this PR to include it

All the integer casts are due to servo/webrender#3291

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22237)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 27, 2018
@bors-servo
Auto merge of #22237 - Manishearth:wrup, r=pcwalton
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c781bff 
Update webrender

Fixes #22232 , once servo/webrender#3327 lands and I update this PR to include it

All the integer casts are due to servo/webrender#3291

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22237)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 27, 2018
@bors-servo
Auto merge of #22237 - Manishearth:wrup, r=pcwalton
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03ed925 
Update webrender

Fixes #22232 , once servo/webrender#3327 lands and I update this PR to include it

All the integer casts are due to servo/webrender#3291

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22237)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 28, 2018
@bors-servo
Auto merge of #22237 - Manishearth:wrup, r=pcwalton
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d5d022f 
Update webrender

Fixes #22232 , once servo/webrender#3327 lands and I update this PR to include it

All the integer casts are due to servo/webrender#3291

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22237)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 28, 2018
@bors-servo
Auto merge of #22237 - Manishearth:wrup, r=pcwalton
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3bf3367 
Update webrender

Fixes #22232 , once servo/webrender#3327 lands and I update this PR to include it

All the integer casts are due to servo/webrender#3291

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22237)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 28, 2018
@bors-servo
Auto merge of #22237 - Manishearth:wrup, r=pcwalton
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f180b84 
Update webrender

Fixes #22232 , once servo/webrender#3327 lands and I update this PR to include it

All the integer casts are due to servo/webrender#3291

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22237)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 29, 2018

(i was able to verify that this works, btw)
@Darkspirit
Copy link
Contributor Author

@Darkspirit Darkspirit commented Nov 29, 2018

Fixed for me too. Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @Manishearth @LifeIsStrange @Darkspirit
You can’t perform that action at this time.