Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement performance interface extension for PerformanceResourceTiming #22307

Closed
avadacatavra opened this issue Nov 29, 2018 · 12 comments
Closed

Implement performance interface extension for PerformanceResourceTiming #22307

avadacatavra opened this issue Nov 29, 2018 · 12 comments
Labels
A-perf-measurement C-assigned E-easy

Comments

@avadacatavra
Copy link
Contributor

@avadacatavra avadacatavra commented Nov 29, 2018 •
edited by ferjm

Specification

Implement
@avadacatavra avadacatavra mentioned this issue Nov 29, 2018
Open
12 of 19 tasks complete
@highfive
Copy link

@highfive highfive commented Nov 29, 2018

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄
@aditj
Copy link
Contributor

@aditj aditj commented Dec 6, 2018

@highfive: assign me
@highfive highfive added the C-assigned label Dec 6, 2018
@highfive
Copy link

@highfive highfive commented Dec 6, 2018

Hey @aditj! Thanks for your interest in working on this issue. It's now assigned to you!
@aditj
Copy link
Contributor

@aditj aditj commented Dec 10, 2018

@avadacatavra little help please, where do I implement the functions exactly ? Inside /servo/components/script/dom/performanceresourcetiming.rs ?
@ferjm
Copy link
Member

@ferjm ferjm commented Dec 10, 2018

According to the spec, these methods are an extension of the Performance interface. You will need to modify that file to add the new methods and the new event.

The implementation for this interface lives in components/script/dom/performance.rs.

The two methods and the event modify, depend or check the list of stored PerformanceResourceTiming entries, which IIUC are stored here.
@aditj
Copy link
Contributor

@aditj aditj commented Dec 11, 2018

@ferjm Thanks for the help ! Btw will my adding a Field to the Performance structure be a problem elsewhere?
@ferjm
Copy link
Member

@ferjm ferjm commented Dec 11, 2018

That I can't tell for sure. It will likely have some side effects (hopefully good ones :)). For example, it may cause new Web Platform Tests to pass or fail.
@aditj
Copy link
Contributor

@aditj aditj commented Dec 11, 2018

@ferjm Where is the crate for PerformanceBinding written at?
@ferjm
Copy link
Member

@ferjm ferjm commented Dec 11, 2018 •
edited

That code is generated from the WebIDL file by the DOM bindings generator at build time.

You can see the resulting code in your target dir. For example: target/debug/build/script-5bcda76abee0ef78/out/Bindings/PerformanceBinding.rs. Note that the script-* path will likely be different for you.
@aditj aditj mentioned this issue Dec 11, 2018
Closed
2 of 5 tasks complete
@aditj
Copy link
Contributor

@aditj aditj commented Dec 12, 2018

@ferjm Help Please! I have implemented the methods , can you guide me on how to write tests for the same ,also do I mention these methods elsewhere?
@aditj aditj mentioned this issue Dec 12, 2018
Closed
4 of 4 tasks complete
@ferjm
Copy link
Member

@ferjm ferjm commented Dec 12, 2018

@aditj #22431 (review)
@aditj aditj mentioned this issue Jan 3, 2019
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Jan 8, 2019
@bors-servo
Auto merge of #22599 - aditj:patch-1-re, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0ce2c26 
Implement performance interface extension for PerformanceResourceTiming

<!-- Please describe your changes on the following line: -->

(There is a previous closed pull for this #22431)
Implemented the following :
a) Added the maxSize Field to the PerformanceEntryList structure.
b) Implemented the clearResourceTimings, setResourceTimingBufferSize, onresourcetimingbufferfull fuctions for the Performance Structure according to the Interface Specification given at : https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22307 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22599)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 10, 2019
@bors-servo
Auto merge of #22599 - aditj:patch-1-re, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fd94b76 
Implement performance interface extension for PerformanceResourceTiming

<!-- Please describe your changes on the following line: -->

(There is a previous closed pull for this #22431)
Implemented the following :
a) Added the maxSize Field to the PerformanceEntryList structure.
b) Implemented the clearResourceTimings, setResourceTimingBufferSize, onresourcetimingbufferfull fuctions for the Performance Structure according to the Interface Specification given at : https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22307 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22599)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 10, 2019
@bors-servo
Auto merge of #22599 - aditj:patch-1-re, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4d2cdea 
Implement performance interface extension for PerformanceResourceTiming

<!-- Please describe your changes on the following line: -->

(There is a previous closed pull for this #22431)
Implemented the following :
a) Added the maxSize Field to the PerformanceEntryList structure.
b) Implemented the clearResourceTimings, setResourceTimingBufferSize, onresourcetimingbufferfull fuctions for the Performance Structure according to the Interface Specification given at : https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22307 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22599)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 10, 2019
@bors-servo
Auto merge of #22599 - aditj:patch-1-re, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
106f137 
Implement performance interface extension for PerformanceResourceTiming

<!-- Please describe your changes on the following line: -->

(There is a previous closed pull for this #22431)
Implemented the following :
a) Added the maxSize Field to the PerformanceEntryList structure.
b) Implemented the clearResourceTimings, setResourceTimingBufferSize, onresourcetimingbufferfull fuctions for the Performance Structure according to the Interface Specification given at : https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22307 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22599)
<!-- Reviewable:end -->
@Hyperion101010
Copy link
Contributor

@Hyperion101010 Hyperion101010 commented Feb 12, 2019

Please add a tick here , if it is complete #21253
I am working on one of 19 issues , and came to know that there are lot of changes coming by this one
So , it'll help everyone in understanding what tasks are complete will now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-perf-measurement C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Implement performance interface extension for PerformanceResourceTiming
Implement performance interface extension
Implement performance interface extension for PerformanceResourceTiming
5 participants
@ferjm @highfive @avadacatavra @aditj @Hyperion101010
You can’t perform that action at this time.