Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DelayNode node #22369

Open
ferjm opened this issue Dec 5, 2018 · 5 comments
Open

Implement DelayNode node #22369

ferjm opened this issue Dec 5, 2018 · 5 comments

Comments

@ferjm
Copy link
Member

@ferjm ferjm commented Dec 5, 2018

@ferjm ferjm added this to To do in WebAudio Dec 5, 2018
@ferjm ferjm moved this from To do to Backlog in WebAudio Dec 5, 2018
@khodzha
Copy link
Contributor

@khodzha khodzha commented Feb 3, 2020

Is allocating vec of sample_rate*maxDelayTime of f32s okay implementation for this task?

@jdm
Copy link
Member

@jdm jdm commented Feb 10, 2020

@Manishearth Any opinion on the previous question?

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Feb 10, 2020

Yes, except that DelayNodes are also a special part of how cycle handling works (cycles with delay nodes that delay for more than a block are allowed, and cycles without a delay node get one inserted). But the basic delay node implementation can be done as mentioned above.

@coryagoodwin
Copy link

@coryagoodwin coryagoodwin commented Feb 20, 2020

Me and my team will be taking on this issue with assistance from @jdm

@coryagoodwin
Copy link

@coryagoodwin coryagoodwin commented Apr 21, 2020

We are no longer working on this project, but our fork for this project is here: https://github.com/shainamainar/media/blob/master/audio/delay_node.rs

There are some errors in compiling that we were unable to resolve, and since this was a semester project we will not be working as a team after today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
WebAudio
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.