Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAnimations for nodes that are not visible are never removed from the list of running animations #22378
Comments
|
When updating animations as part of regular layout, we should be able to check if there is a fragment associated with the animation's node. If there is not, it is either outside the document or display: none, so we could expire the animation. |
|
We should have a testcase for changing the element's style display to none, as well. |
|
This can happen in recalc_style_for_animations by tracking which animations in |
bors-servo
added a commit
that referenced
this issue
Dec 8, 2018
Cancel animations that affect nodes that do not participate in layout. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22378 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Dec 8, 2018
Cancel animations that affect nodes that do not participate in layout. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22378 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Dec 8, 2018
Cancel animations that affect nodes that do not participate in layout. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22378 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Dec 10, 2018
Cancel animations that affect nodes that do not participate in layout. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22378 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Dec 10, 2018
Cancel animations that affect nodes that do not participate in layout. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22378 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Dec 10, 2018
Cancel animations that affect nodes that do not participate in layout. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22378 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you look at the list of layout events, the animation continues triggering after the node is removed from the document.