Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent failure in /_mozilla/mozilla/animation-removed-node.html #22445

Open
jdm opened this issue Dec 13, 2018 · 1 comment
Open

Intermittent failure in /_mozilla/mozilla/animation-removed-node.html #22445

jdm opened this issue Dec 13, 2018 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 13, 2018

{"status": "FAIL", "group": "default", "message": "assert_equals: expected 0 but got 1", "stack": "window.onload</<@http://web-platform.test:8000/_mozilla/mozilla/animation-removed-node.html:23:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1566:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1590:20\n", "subtest": "Animations are no longer active when a node can't be animated.", "test": "/_mozilla/mozilla/animation-removed-node.html", "line": 149673, "action": "test_result", "expected": "PASS"}

Maybe two requestAnimationFrame calls will do the trick :<

@jdm jdm added the I-intermittent label Dec 13, 2018
bors-servo added a commit that referenced this issue Dec 14, 2018
Add another layer of rAF to avoid intermittent failures.

Hopefully fixes #22445.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22447)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 15, 2018
Add another layer of rAF to avoid intermittent failures.

Hopefully fixes #22445.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22447)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 15, 2018
Add another layer of rAF to avoid intermittent failures.

Hopefully fixes #22445.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22447)
<!-- Reviewable:end -->
@CYBAI
Copy link
Collaborator

@CYBAI CYBAI commented Dec 16, 2018

It seems here comes different intermittent failure for the same test. ( #22467 and #22451 )

{
    "status": "FAIL", 
    "group": "default", 
    "message": "missing ) after argument list", 
    "stack": "http://web-platform.test:8000/_mozilla/mozilla/animation-removed-node.html:26:10", 
    "subtest": "animation-removed-node", 
    "test": "/_mozilla/mozilla/animation-removed-node.html", 
    "line": 148028, 
    "action": "test_result", 
    "expected": "PASS"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.