Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWhen exiting, monitored component should unregister itself #22468
Comments
bors-servo
added a commit
that referenced
this issue
Dec 18, 2018
Unregister components while exiting r=@gterzian <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22468 (GitHub issue number if applicable) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22474) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Dec 18, 2018
Unregister components while exiting r=@gterzian <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22468 (GitHub issue number if applicable) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22474) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A component currently registered with the background-hang-monitor will start "hanging" after exiting, because it doesn't unregister itself, nor does it go into "waiting" mode, instead, it handles the last "exit" task, and quits. From the monitor's perspective, the component will later start hanging on that last "exit" task.
This will require:
Unregistermessageservo/components/background_hang_monitor/background_hang_monitor.rs
Line 72 in c9229f3
unregistermethod, either for this or that trait(I would say ratherBackgroundHangMonitor), as well as corresponding implementations.notify_activity, followed by unregistering itself, followed by either sleeping until the timeout is reached, or quitting.