servo / servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide real keyboard code values on non-linux platforms #22486

Open

jdm opened this issue Dec 17, 2018 · 0 comments

Labels

A-input P-mac P-windows

Member

jdm commented Dec 17, 2018

The function to convert a winit scancode to a keyboard_types::Code value is unimplemented on mac and windows:

servo/ports/servo/glutin_app/keyutils.rs

Lines 238 to 242 in 9ca6768

    
           #[cfg(not(target_os = "linux"))] 
        
           fn get_servo_code_from_scancode(_scancode: u32) -> Code { 
        
               // TODO: Implement for Windows and Mac OS 
        
               Code::Unidentified 
        
           }

. This could lead to surprising webcompat issues when testing servo on these platforms and trying to use the keyboard.

jdm added P-mac P-windows A-input labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.