Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmacOS WPT taskcluster job is busted #22497
Comments
|
I am unclear why this does not appear on #22459 itself. |
|
Looks like the |
After |
|
|
|
I have manually updated the older copy, so this should no longer prevent merging anything. |
|
If we're not explicitly upgrading homebrew packages on workers as part of CI, then the only time this should affect us is when provisioning new builders, which will end up installing the latest package version. |
|
Another possible case is if we add a new dependency. It’ll be installed on each worker the first time there’s a build job, which may vary across builder. It is unlikely but possible that a new version is published in that window. But really, shouldn’t we be statically linking harfbuzz and (some) other dependencies? Then this issue wouldn’t exist in the first place. |
|
Yeah, we should probably be setting the HARFBUZZ_SYS_NO_PKG_CONFIG variable so we don't short-circuit at https://github.com/servo/rust-harfbuzz/blob/master/harfbuzz-sys/build.rs#L10-L14. |
|
Could we instead use |
Every PR since #22459 has failed when running this task:
with errors like: