Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFetch abortion for file urls does not work #22510
Comments
|
It might be true that we don't yet support cancellation, but since we're using asynchronous communication we also cannot guarantee that no more response chunks will be received after cancelling a fetch. Consumers need to store some kind of state that allows them to ignore unwanted data. |
|
Yeah, I don't expect to receive zero response chunks after cancellation, but to stop receiving them at some point before EOF :). That's what happens with fetch cancellation for http urls. |
|
That still might not be a reasonable expectation, since the file reading will be streaming chunks across the channel as fast as it can read them. |
I still see
process_response_chunkcalls coming after cancelling a fetch request to a file:// url.