Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch abortion for file urls does not work #22510

Open
ferjm opened this issue Dec 20, 2018 · 3 comments
Open

Fetch abortion for file urls does not work #22510

ferjm opened this issue Dec 20, 2018 · 3 comments
Labels

Comments

@ferjm
Copy link
Member

@ferjm ferjm commented Dec 20, 2018

I still see process_response_chunk calls coming after cancelling a fetch request to a file:// url.

@ferjm ferjm added the A-network label Dec 20, 2018
@jdm
Copy link
Member

@jdm jdm commented Dec 20, 2018

It might be true that we don't yet support cancellation, but since we're using asynchronous communication we also cannot guarantee that no more response chunks will be received after cancelling a fetch. Consumers need to store some kind of state that allows them to ignore unwanted data.

@ferjm
Copy link
Member Author

@ferjm ferjm commented Dec 20, 2018

Yeah, I don't expect to receive zero response chunks after cancellation, but to stop receiving them at some point before EOF :). That's what happens with fetch cancellation for http urls.

@ferjm ferjm changed the title Fetch abortation for file urls does not work Fetch abortion for file urls does not work Dec 20, 2018
@jdm
Copy link
Member

@jdm jdm commented Dec 20, 2018

That still might not be a reasonable expectation, since the file reading will be streaming chunks across the channel as fast as it can read them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.