Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement browsing context targetting for HTMLAreaElement #22515

Closed
jdm opened this issue Dec 20, 2018 · 5 comments
Closed

Implement browsing context targetting for HTMLAreaElement #22515

jdm opened this issue Dec 20, 2018 · 5 comments
Labels
A-content/dom C-assigned E-candidate-for-mentoring

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 20, 2018

We support targeting browsing contexts since #20678 (see the code in htmlanchorelement.rs that deals with the target attribute), so we should implement this missing feature. It's used in the referrer-policy/generic/subresource-test/area-navigate.html test.
@georgeroman
Copy link
Contributor

@georgeroman georgeroman commented Jan 25, 2019

@highfive assign me
@highfive highfive added the C-assigned label Jan 25, 2019
@highfive
Copy link

@highfive highfive commented Jan 25, 2019

Hey @georgeroman! Thanks for your interest in working on this issue. It's now assigned to you!
@georgeroman
Copy link
Contributor

@georgeroman georgeroman commented Jan 25, 2019

I managed to make the area-navigate test to result in FAIL instead of TIMEOUT by simply implementing the methods in HTMLHyperlinkElementUtils. Is this the desired result, or I should only add support for the target attribute for now?
@jdm
Copy link
Member Author

@jdm jdm commented Jan 25, 2019

Oh, good catch! Please add the support for the target attribute on top of that work!
@georgeroman georgeroman mentioned this issue Feb 8, 2019
Merged
3 of 3 tasks complete
@georgeroman
Copy link
Contributor

@georgeroman georgeroman commented Feb 8, 2019

In the end I didn't manage to make the test go from TIMEOUT to FAIL, so I made a PR just with the implementation of the target attribute: #22850. However, I'll keep trying.
bors-servo added a commit that referenced this issue Feb 8, 2019
@bors-servo
Auto merge of #22850 - georgeroman:implement_htmlareaelement_target_a…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a6b3213 
…ttribute, r=<try>

Implement the target attribute for HTMLAreaElement

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22515

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22850)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 11, 2019
@bors-servo
Auto merge of #22850 - georgeroman:implement_htmlareaelement_target_a…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
921ce41 
…ttribute, r=ferjm

Implement the target attribute for HTMLAreaElement

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22515

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22850)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 11, 2019
@bors-servo
Auto merge of #22850 - georgeroman:implement_htmlareaelement_target_a…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3756efe 
…ttribute, r=<try>

Implement the target attribute for HTMLAreaElement

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22515

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22850)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 11, 2019
@bors-servo
Auto merge of #22850 - georgeroman:implement_htmlareaelement_target_a…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7ed6b9d 
…ttribute, r=ferjm

Implement the target attribute for HTMLAreaElement

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22515

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22850)
<!-- Reviewable:end -->
@jdm jdm reopened this Feb 11, 2019
@jdm jdm closed this Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-candidate-for-mentoring
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Implement the target attribute for HTMLAreaElement
3 participants
@jdm @highfive @georgeroman
You can’t perform that action at this time.