Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make child_iter in Flows not borrow the whole flow #2253

Open
pcwalton opened this issue Apr 28, 2014 · 0 comments
Open

Make child_iter in Flows not borrow the whole flow #2253

pcwalton opened this issue Apr 28, 2014 · 0 comments

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Apr 28, 2014

It would be nice if child_iter didn't borrow the whole flow. Rust is being conservative here, because it doesn't know that the structure of the flow tree is guaranteed to be immutable during layout and is trying to guard against iterator invalidation. However, we already have to guarantee that the structure of the flow tree is immutable for parallel layout to be safe, so the iterator invalidation guarantees on child_iter aren't buying us anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.