Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent crash in /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html #22584

Closed
jdm opened this issue Dec 31, 2018 · 0 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 31, 2018

  ▶ CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html
  │ 
  │ VMware, Inc.
  │ softpipe
  │ 3.3 (Core Profile) Mesa 18.3.0-devel
  │ Layout thread disconnected.: "SendError(..)" (thread ScriptThread PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }, at src/libcore/result.rs:999)
  │ stack backtrace:
  │    0:     0x7fdcc060940d - backtrace::backtrace::trace::h79f1388f62af1802
  │    1:     0x7fdcc06084f2 - backtrace::capture::Backtrace::new::hc3bba4c59ac369f9
  │    2:     0x7fdcbe0ec707 - servo::main::{{closure}}::hf19b374ab533c127
  │    3:     0x7fdcc12e3169 - std::panicking::rust_panic_with_hook::h4ae0c8352236ab41
  │                         at src/libstd/panicking.rs:482
  │    4:     0x7fdcc12e2c11 - std::panicking::continue_panic_fmt::h3111c2662a27401f
  │                         at src/libstd/panicking.rs:385
  │    5:     0x7fdcc12e2af5 - rust_begin_unwind
  │                         at src/libstd/panicking.rs:312
  │    6:     0x7fdcc130288c - core::panicking::panic_fmt::h9b22f2eab14691b2
  │                         at src/libcore/panicking.rs:85
  │    7:     0x7fdcbecab549 - core::result::unwrap_failed::hd73a15296c74d9b9
  │    8:     0x7fdcbe6cd5d4 - script::dom::window::Window::force_reflow::h53978208f3a3c509
  │    9:     0x7fdcbe6cdd70 - script::dom::window::Window::reflow::heddd495561cc9402
  │   10:     0x7fdcbe9d0667 - script::dom::document::Document::finish_load::h6d5c5438ae1a0bd3
  │   11:     0x7fdcbe762a8f - script::dom::servoparser::ServoParser::do_parse_sync::h5fa2c01154ba2fd0
  │   12:     0x7fdcbeae5652 - profile_traits::time::profile::h77044da60d2c5250
  │   13:     0x7fdcbe762130 - _ZN6script3dom11servoparser11ServoParser10parse_sync17ha4fd06fc285ee4c9E.llvm.9339690625470186472
  │   14:     0x7fdcbe76829f - <script::dom::servoparser::ParserContext as net_traits::FetchResponseListener>::process_response_eof::h2d88f23e27a56c4e
  │   15:     0x7fdcbebfed50 - script::script_thread::ScriptThread::handle_msg_from_constellation::h42a0e4ca9312c959
  │   16:     0x7fdcbebf5cd5 - script::script_thread::ScriptThread::handle_msgs::{{closure}}::h50dd6c3e534ef2de
  │   17:     0x7fdcbebf21d0 - _ZN6script13script_thread12ScriptThread11handle_msgs17h470952e4622057d7E.llvm.16015583961693140166
  │   18:     0x7fdcbebedb16 - script::script_thread::ScriptThread::start::h15ea86fa7a7fa212
  │   19:     0x7fdcbec7e92e - profile_traits::mem::ProfilerChan::run_with_memory_reporting::hca3d66b9290e91c7
  │   20:     0x7fdcbed77ee4 - std::sys_common::backtrace::__rust_begin_short_backtrace::h8489019698b0aeef
  │   21:     0x7fdcbf2c41c5 - _ZN3std9panicking3try7do_call17h352587cb1a98b0eeE.llvm.18296174844099702026
  │   22:     0x7fdcc12ede79 - __rust_maybe_catch_panic
  │                         at src/libpanic_unwind/lib.rs:92
  │   23:     0x7fdcbeef8387 - <F as alloc::boxed::FnBox<A>>::call_box::hbb3f60dda289794c
  │   24:     0x7fdcc12ed22d - <alloc::boxed::Box<(dyn alloc::boxed::FnBox<A, Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$RP$$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h6f2a2148ffb0bc67
  │                         at /rustc/fb86d604bf65c3becd16180b56267a329cf268d5/src/liballoc/boxed.rs:734
  │                          - std::sys_common::thread::start_thread::h484e653ee0a7a7a3
  │                         at src/libstd/sys_common/thread.rs:14
  │                          - std::sys::unix::thread::Thread::new::thread_start::h9d911af69d8eb4e6
  │                         at src/libstd/sys/unix/thread.rs:81
  │   25:     0x7fdcbbd38183 - start_thread
  │   26:     0x7fdcba5ff03c - clone
  │   27:                0x0 - <unknown>
  │ [2018-12-28T15:09:39Z ERROR servo] Layout thread disconnected.: "SendError(..)"
  └ Pipeline failed in hard-fail mode.  Crashing!
@jdm jdm added the I-intermittent label Dec 31, 2018
@alarsyo alarsyo mentioned this issue Jul 4, 2020
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jul 4, 2020
…es-panic, r=jdm

Return Option for Window's layout channel

<!-- Please describe your changes on the following line: -->

`Window::layout_chan()` now returns an `Option<Sender<Msg>>`, returning `None` if the window is dead.

FIX #26969
FIX #26429
FIX #21208
FIX #19092
FIX #22559
FIX #22584
FIX #22652

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23053

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

This is my first contribution, I'm trying to figure things out!

This fix passes the test case shown in #23053, however I don't know what the behavior should be in `Document` and `ScriptThread` if `Window::is_alive()` is false : simply ignore it, don't do anything ? Or is this something that should not happen now that we return false in `Window::force_reflow()` ?

I'm not sure about the directory where the test case should go, any advice?
@bors-servo bors-servo closed this in 8916a42 Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.