Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Box::new_line_pos #2260

Closed
pcwalton opened this issue Apr 29, 2014 · 0 comments
Closed

Remove Box::new_line_pos #2260

pcwalton opened this issue Apr 29, 2014 · 0 comments
Labels
A-layout/text I-perf-bloat I-perf-slow I-refactor

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Apr 29, 2014

It's pretty inefficient and I don't think it's necessary.
@pcwalton pcwalton mentioned this issue Apr 29, 2014
Merged
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 2, 2015
@pcwalton
layout: Simplify and improve the correctness of whitespace stripping in
c761092 
text layout, and unify the inline layout paths for pre- and
normally-formatted text.

This fixes a lot of "jumpiness" and removes the `new_line_pos` stuff.

Closes servo#2260.
@pcwalton pcwalton mentioned this issue Apr 2, 2015
Merged
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 7, 2015
@pcwalton
layout: Simplify and improve the correctness of whitespace stripping in
64ee4a8 
text layout, and unify the inline layout paths for pre- and
normally-formatted text.

This fixes a lot of "jumpiness" and removes the `new_line_pos` stuff.

Closes servo#2260.
bors-servo pushed a commit that referenced this issue Apr 7, 2015
bors-servo
Auto merge of #5493 - pcwalton:jumpiness, r=mbrubeck
f7bb5c1 
This fixes a lot of "jumpiness" and removes the `new_line_pos` stuff.

Closes #2260.

r? @mbrubeck
cc @metajack
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 7, 2015
@pcwalton
layout: Simplify and improve the correctness of whitespace stripping in
d7905ef 
text layout, and unify the inline layout paths for pre- and
normally-formatted text.

This fixes a lot of "jumpiness" and removes the `new_line_pos` stuff.

Closes servo#2260.
bors-servo pushed a commit that referenced this issue Apr 8, 2015
bors-servo
Auto merge of #5493 - pcwalton:jumpiness, r=mbrubeck
e07aa3c 
This fixes a lot of "jumpiness" and removes the `new_line_pos` stuff.

Closes #2260.

r? @mbrubeck
cc @metajack
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 8, 2015
@pcwalton
layout: Simplify and improve the correctness of whitespace stripping in
59a5664 
text layout, and unify the inline layout paths for pre- and
normally-formatted text.

This fixes a lot of "jumpiness" and removes the `new_line_pos` stuff.

Closes servo#2260.
bors-servo pushed a commit that referenced this issue Apr 8, 2015
bors-servo
Auto merge of #5493 - pcwalton:jumpiness, r=mbrubeck
6e35030 
This fixes a lot of "jumpiness" and removes the `new_line_pos` stuff.

Closes #2260.

r? @mbrubeck
cc @metajack
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 8, 2015
@pcwalton
layout: Simplify and improve the correctness of whitespace stripping in
6d61468 
text layout, and unify the inline layout paths for pre- and
normally-formatted text.

This fixes a lot of "jumpiness" and removes the `new_line_pos` stuff.

Closes servo#2260.
bors-servo pushed a commit that referenced this issue Apr 8, 2015
bors-servo
Auto merge of #5493 - pcwalton:jumpiness, r=mbrubeck
Loading status checks…
d347895 
This fixes a lot of "jumpiness" and removes the `new_line_pos` stuff.

Closes #2260.

r? @mbrubeck
cc @metajack
@pyfisch pyfisch mentioned this issue Jan 4, 2018
Open
4 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/text I-perf-bloat I-perf-slow I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

layout: Simplify and improve the correctness of whitespace stripping in text layout, and unify the inline layout paths for pre- and normally-formatted text.
1 participant
@pcwalton
You can’t perform that action at this time.