Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging should not have side effects #2263

Closed
pcwalton opened this issue Apr 29, 2014 · 1 comment
Closed

Logging should not have side effects #2263

pcwalton opened this issue Apr 29, 2014 · 1 comment
Labels
A-layout/uncategorized E-easy I-refactor

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Apr 29, 2014

RUST_LOG is for logging, not for side effects like displaying debug borders around boxes. Make this a separate option in Opts.
@pcwalton pcwalton mentioned this issue Apr 29, 2014
Merged
@ebalint
Copy link
Contributor

@ebalint ebalint commented Jun 4, 2014

I started working on this
mrobinson added a commit to mrobinson/servo that referenced this issue Oct 20, 2014
@mrobinson
Add an option to show debug fragment borders
2f47d2e 
This is quite a bit cleaner than abusing the rust debug functionality.
If we start collecting too many debugging options in the servo
executable we could opt to organize them into a single option.

Fixes servo#2263.
@mrobinson mrobinson mentioned this issue Oct 20, 2014
Merged
mrobinson added a commit to mrobinson/servo that referenced this issue Oct 21, 2014
@mrobinson
Add an option to show debug fragment borders
5d79699 
This is quite a bit cleaner than abusing the rust debug functionality.
If we start collecting too many debugging options in the servo
executable we could opt to organize them into a single option.

Fixes servo#2263.
bors-servo pushed a commit that referenced this issue Oct 21, 2014
bors-servo
auto merge of #3746 : mrobinson/servo/debug-fragment-borders, r=pcwalton
Loading status checks…
35c689f 
This is quite a bit cleaner than abusing the rust debug functionality.
If we start collecting too many debugging options in the servo
executable we could opt to organize them into a single option.

Fixes #2263.
mrobinson added a commit to mrobinson/servo that referenced this issue Oct 21, 2014
@mrobinson
Add an option to show debug fragment borders
9f7d786 
This is quite a bit cleaner than abusing the rust debug functionality.
If we start collecting too many debugging options in the servo
executable we could opt to organize them into a single option.

Fixes servo#2263.
bors-servo pushed a commit that referenced this issue Oct 21, 2014
bors-servo
auto merge of #3746 : mrobinson/servo/debug-fragment-borders, r=pcwalton
Loading status checks…
3bca425 
This is quite a bit cleaner than abusing the rust debug functionality.
If we start collecting too many debugging options in the servo
executable we could opt to organize them into a single option.

Fixes #2263.
mrobinson added a commit to mrobinson/servo that referenced this issue Oct 21, 2014
@mrobinson
Add an option to show debug fragment borders
2d5168a 
This is quite a bit cleaner than abusing the rust debug functionality.
If we start collecting too many debugging options in the servo
executable we could opt to organize them into a single option.

Fixes servo#2263.
bors-servo pushed a commit that referenced this issue Oct 21, 2014
bors-servo
auto merge of #3746 : mrobinson/servo/debug-fragment-borders, r=pcwalton
Loading status checks…
7c9d3dd 
This is quite a bit cleaner than abusing the rust debug functionality.
If we start collecting too many debugging options in the servo
executable we could opt to organize them into a single option.

Fixes #2263.
bors-servo pushed a commit that referenced this issue Oct 21, 2014
bors-servo
auto merge of #3746 : mrobinson/servo/debug-fragment-borders, r=pcwalton
Loading status checks…
3936d14 
This is quite a bit cleaner than abusing the rust debug functionality.
If we start collecting too many debugging options in the servo
executable we could opt to organize them into a single option.

Fixes #2263.
mukilan added a commit to mukilan/servo that referenced this issue Oct 25, 2014
@mrobinson @mukilan
Add an option to show debug fragment borders
6d583c2 
This is quite a bit cleaner than abusing the rust debug functionality.
If we start collecting too many debugging options in the servo
executable we could opt to organize them into a single option.

Fixes servo#2263.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/uncategorized E-easy I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add an option to show debug fragment borders
2 participants
@pcwalton @ebalint
You can’t perform that action at this time.