Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize `construct::strip_ignorable_whitespace_from_start` #2264

Open
pcwalton opened this issue Apr 29, 2014 · 3 comments
Open

Optimize `construct::strip_ignorable_whitespace_from_start` #2264

pcwalton opened this issue Apr 29, 2014 · 3 comments
Labels
A-layout/tree-builder I-perf-slow

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Apr 29, 2014

I think it's O(n^2), which is bad.
@pcwalton pcwalton mentioned this issue Apr 29, 2014
Merged
@nox
Copy link
Member

@nox nox commented Sep 30, 2017

Is this still true?
@pcwalton
Copy link
Contributor Author

@pcwalton pcwalton commented Jan 18, 2018

Probably, yeah.
@dralley
Copy link
Contributor

@dralley dralley commented Mar 25, 2020

The implementation was completely changed here: bb6f557

Although I don't know whether the algorithmic properties are significantly better or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/tree-builder I-perf-slow
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@nox @pcwalton @dralley
You can’t perform that action at this time.