Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove from OrderedMap to IndexMap for custom properties #22643
Closed
Labels
Comments
|
@highfive assign me |
|
Hey @shanavas786! Thanks for your interest in working on this issue. It's now assigned to you! |
bors-servo
added a commit
that referenced
this issue
Jan 10, 2019
Remove OrderedMap in favor of IndexMap <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22643 <!-- Either: --> - [x] These changes do not require tests because its just refactoring <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22656) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #22555 merged, we've introduced the
indexmapcrate.There's a similar implementation in custom properies called
OrderedMap.servo/components/style/custom_properties.rs
Lines 143 to 153 in bffe2a6
It would be great to reuse the
indexmapcrate and remove theOrderedMapinstead.cc @emilio