Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User scripts trigger panic #22685

Closed
jdm opened this issue Jan 14, 2019 · 0 comments
Closed

User scripts trigger panic #22685

jdm opened this issue Jan 14, 2019 · 0 comments
Assignees
@jdm
Labels
A-content/script I-panic

Comments

@jdm
Copy link
Member

@jdm jdm commented Jan 14, 2019 

godot:MacOS jdm$ ./servo 'https://www.youtube.com/watch?v=zmFYgc-Emmc&feature=youtu.be' --userscripts=/Users/jdm/src/
[2019-01-14T23:32:49Z ERROR script::dom::bindings::error] Error at :1:0 illegal character
assertion failed: window.Document().can_invoke_script() (thread ScriptThread PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }, at components/script/dom/eventtarget.rs:378)
@jdm jdm self-assigned this Jan 14, 2019
@jdm jdm mentioned this issue Jan 15, 2019
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jan 15, 2019
@bors-servo
Auto merge of #22697 - jdm:user-script, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
91d7747 
Don't panic when executing userscripts

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22685
- [x] These changes do not require tests because there is no automation for testing userscripts.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22697)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 16, 2019
@bors-servo
Auto merge of #22697 - jdm:user-script, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7400219 
Don't panic when executing userscripts

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22685
- [x] These changes do not require tests because there is no automation for testing userscripts.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22697)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdm jdm

Labels
A-content/script I-panic
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Don't panic when executing userscripts
1 participant
@jdm
You can’t perform that action at this time.