Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement missing "insert a foreign element" parsing algorithm #22695
Comments
|
@jdm Can you provide some more context here please? |
|
It took me a while to read and understand what it was about, but the fundamental change is this commit. From reading Servo's html5 parser implementation, it looks like it's modifying an algorithm that has changed since we originally implemented it. I think I see a few important steps here - currently, the html5ever parser implements the "create an element for the token" algorithm here (spec), but we're missing the "insert a foreign element" algorithm that the HTML specification PR changed (https://html.spec.whatwg.org/multipage/parsing.html#insert-a-foreign-element). We should:
I believe those changes should allow us to pass some tests that are currently failing. |
|
The test to run would be |
|
And Servo's parser implementation lives in |
|
Thanks @jdm so much. I'll take a stab at it. |
whatwg/html#4290