Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click events get repeated on android #22702

Closed
Manishearth opened this issue Jan 16, 2019 · 2 comments
Closed

Click events get repeated on android #22702

Manishearth opened this issue Jan 16, 2019 · 2 comments
Labels

Comments

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Jan 16, 2019

I'm not able to consistently reproduce this, but with a simple webpage with a click handler on a button, the click event sometimes gets triggered multiple times on android.

I think it depends on how you click it, but I'm not quite sure.

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jan 16, 2019

A tap will explicitly generate a click:

Not sure if we are getting 2 taps or if it's something more convoluted.

@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented Jan 16, 2019

Ah! Servo internally already has logic for converting touch events into click events. Adding support for touch events (#22229) broke this.

We simply need to remove any non-tap handlers.

Manishearth added a commit to Manishearth/servo that referenced this issue Jan 16, 2019
Servo already can simulate clicks from multiple tap events

fixes servo#22702
bors-servo added a commit that referenced this issue Jan 17, 2019
Stop catching Android click events

Servo already can simulate clicks from multiple tap events

fixes #22702

r? @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22708)
<!-- Reviewable:end -->
gterzian added a commit to gterzian/servo that referenced this issue Jan 30, 2019
Servo already can simulate clicks from multiple tap events

fixes servo#22702
aditj added a commit to aditj/servo that referenced this issue Jan 30, 2019
Servo already can simulate clicks from multiple tap events

fixes servo#22702
aditj added a commit to aditj/servo that referenced this issue Mar 15, 2019
Servo already can simulate clicks from multiple tap events

fixes servo#22702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.