Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLayout for <input type="range"> #22728
Open
Assignees
Labels
Comments
Merged
bors-servo
added a commit
that referenced
this issue
May 13, 2019
Media controls <strike>This is still highly WIP. It depends on #22743 and so it is based on top of it. The basic controls functionality is there, but the layout is highly broken. There is a hack to at least make the controls render on top of the video, but it is not correctly positioned. The controls' div container ends up as sibbling of the media element in the flow tree while IIUC it should end up as a child.</strike> - [X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [X] These changes fix #22721 and #22720 There is at least an extra dependency to improve the functionality and visual aspect: #22728. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23208) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 14, 2019
Media controls <strike>This is still highly WIP. It depends on #22743 and so it is based on top of it. The basic controls functionality is there, but the layout is highly broken. There is a hack to at least make the controls render on top of the video, but it is not correctly positioned. The controls' div container ends up as sibbling of the media element in the flow tree while IIUC it should end up as a child.</strike> - [X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [X] These changes fix #22721 and #22720 There is at least an extra dependency to improve the functionality and visual aspect: #22728. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23208) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 14, 2019
Media controls <strike>This is still highly WIP. It depends on #22743 and so it is based on top of it. The basic controls functionality is there, but the layout is highly broken. There is a hack to at least make the controls render on top of the video, but it is not correctly positioned. The controls' div container ends up as sibbling of the media element in the flow tree while IIUC it should end up as a child.</strike> - [X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [X] These changes fix #22721 and #22720 There is at least an extra dependency to improve the functionality and visual aspect: #22728. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23208) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 23, 2019
Media controls <strike>This is still highly WIP. It depends on #22743 and so it is based on top of it. The basic controls functionality is there, but the layout is highly broken. There is a hack to at least make the controls render on top of the video, but it is not correctly positioned. The controls' div container ends up as sibbling of the media element in the flow tree while IIUC it should end up as a child.</strike> - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [X] These changes fix #22721 and fix #22720 There is at least an extra dependency to improve the functionality and visual aspect: #22728. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23208) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 23, 2019
Media controls <strike>This is still highly WIP. It depends on #22743 and so it is based on top of it. The basic controls functionality is there, but the layout is highly broken. There is a hack to at least make the controls render on top of the video, but it is not correctly positioned. The controls' div container ends up as sibbling of the media element in the flow tree while IIUC it should end up as a child.</strike> - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [X] These changes fix #22721 and fix #22720 There is at least an extra dependency to improve the functionality and visual aspect: #22728. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23208) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now
<input type="range">renders like a text input, while it should render like a slider with a thumb.Servo:
Firefox:
