Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of "got script tick after closure" when visiting various ML homepage sites and going back in history #22746

Open
jdm opened this issue Jan 22, 2019 · 3 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Jan 22, 2019

I suspect the transparent rectangles page started some persistent rAF loop that didn't get cancelled.

@jdm jdm added the I-perf-slow label Jan 22, 2019
@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jan 22, 2019

@jdm is this replicable on not-magicleap servo? It sounds like the rAF thread isn't responding to freeze properly.

@jdm
Copy link
Member Author

@jdm jdm commented Jan 23, 2019

I can reproduce this on desktop; if I load the transparent rects demo then load another page, I keep seeing the FPS counter in the terminal from console.log statements that happen in the previous page's rAF event.

@jdm
Copy link
Member Author

@jdm jdm commented Jan 23, 2019

This compositor code doesn't take into account whether a pipeline is frozen or not; neither does this constellation code. It would probably be best to avoid sending the message from the compositor if the necessary information is available at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.